Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: internal/errors should not be executable #16369

Closed
wants to merge 1 commit into from
Closed

lib: internal/errors should not be executable #16369

wants to merge 1 commit into from

Conversation

maclover7
Copy link
Contributor

Checklist
Affected core subsystem(s)

lib

@nodejs-github-bot nodejs-github-bot added the errors Issues and PRs related to JavaScript errors originated in Node.js core. label Oct 21, 2017
TimothyGu
TimothyGu approved these changes Oct 21, 2017
View reviewed changes
Copy link
Member

@TimothyGu TimothyGu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasnell :)

@jasnell
Copy link
Member

jasnell commented Oct 21, 2017

Sigh. This is what I get for recreating my virtual machines. I always forget to set git to ignore file mode changes.

@Trott
Copy link
Member

Trott commented Oct 23, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/10924/

jasnell pushed a commit that referenced this pull request Oct 24, 2017
@maclover7 @jasnell
lib: internal/errors should not be executable
88799dd 
PR-URL: #16369
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
@jasnell
Copy link
Member

jasnell commented Oct 24, 2017

Landed in 88799dd

@jasnell jasnell closed this Oct 24, 2017
@maclover7 maclover7 deleted the jm-rm-exec branch October 24, 2017 13:05
addaleax pushed a commit to ayojs/ayo that referenced this pull request Oct 26, 2017
@maclover7 @addaleax
lib: internal/errors should not be executable
c14a890 
PR-URL: nodejs/node#16369
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
@jasnell jasnell mentioned this pull request Oct 30, 2017
Merged
gibfahn pushed a commit that referenced this pull request Oct 30, 2017
@maclover7 @gibfahn
lib: internal/errors should not be executable
c3705d0 
PR-URL: #16369
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
gibfahn pushed a commit that referenced this pull request Oct 31, 2017
@maclover7 @gibfahn
lib: internal/errors should not be executable
3a230b4 
PR-URL: #16369
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
@gibfahn gibfahn mentioned this pull request Oct 31, 2017
Merged
addaleax pushed a commit to ayojs/ayo that referenced this pull request Dec 7, 2017
@maclover7 @addaleax
lib: internal/errors should not be executable
6248e42 
PR-URL: nodejs/node#16369
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
This was referenced May 13, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@lpinca lpinca lpinca approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@gibfahn gibfahn gibfahn approved these changes

Assignees
No one assigned
Labels
errors Issues and PRs related to JavaScript errors originated in Node.js core.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.