Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: remove duplicate options #16339

Closed
wants to merge 1 commit into from
Closed

doc: remove duplicate options #16339

wants to merge 1 commit into from

Conversation

hyades
Copy link

@hyades hyades commented Oct 20, 2017

Fixes: #16332

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

@nodejs-github-bot nodejs-github-bot added child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to the documentations. labels Oct 20, 2017
jasnell
jasnell approved these changes Oct 20, 2017
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not need to wait the 48 hours to land

vsemozhetbyt pushed a commit that referenced this pull request Oct 20, 2017
@vsemozhetbyt
doc: remove duplicate options
686e092 
PR-URL: #16339
Fixes: #16332
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
@vsemozhetbyt
Copy link
Contributor

Landed in 686e092

Thank you, @hyades!

@vsemozhetbyt
Copy link
Contributor

Erm.. Does anybody know what happens?
1

@vsemozhetbyt vsemozhetbyt reopened this Oct 20, 2017
@apapirovski
Copy link
Member

@vsemozhetbyt it's just because @hyades didn't correctly setup their local github config or their github account is missing that particular email address.

@hyades if you would like to have this commit associated with your account, you can add that email to your github list of emails and then you'll be promoted to 'Contributor'.

@vsemozhetbyt
Copy link
Contributor

Maybe we should add something about local and GitHub emails sync in CONTRIBUTING.md

@apapirovski
Copy link
Member

I believe there is already a note there re: setting your local config.name and config.email. I guess we could expand by mentioning that if you have multiple emails you can add them all in github?

@vsemozhetbyt vsemozhetbyt mentioned this pull request Oct 20, 2017
Closed
2 tasks
@vsemozhetbyt
Copy link
Contributor

A try: #16340

@hyades
Copy link
Author

hyades commented Oct 20, 2017

@vsemozhetbyt @apapirovski My bad. Gave the wrong user.email for the repo. Now added it to github profile.

@vsemozhetbyt
Copy link
Contributor

Commit info is updated. It is a pity the contributor status is not assigned after a fix post-factum(
Could we do something manually?

gireeshpunathil pushed a commit that referenced this pull request Oct 21, 2017
@vsemozhetbyt @gireeshpunathil
meta: add note about email sync to CONTRIBUTING.md
6d4c685 
PR-URL: #16340
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>

Refs: #16339 (comment)
@vsemozhetbyt vsemozhetbyt mentioned this pull request Oct 21, 2017
Closed
2 tasks
@gibfahn
Copy link
Member

gibfahn commented Oct 22, 2017

Commit info is updated. It is a pity the contributor status is not assigned after a fix post-factum(
Could we do something manually?

So I don't know if it's because I emailed GitHub support, or a coincidence, but @hyades is now listed as a Contributor (although I swear they weren't this morning).

image

So congratulations @hyades on becoming a Node.js contributor!

MylesBorins pushed a commit that referenced this pull request Oct 23, 2017
@MylesBorins
doc: remove duplicate options
d57f358 
PR-URL: #16339
Fixes: #16332
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 23, 2017
@vsemozhetbyt @MylesBorins
meta: add note about email sync to CONTRIBUTING.md
fd54d8a 
PR-URL: #16340
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>

Refs: #16339 (comment)
addaleax pushed a commit to ayojs/ayo that referenced this pull request Oct 26, 2017
@addaleax
doc: remove duplicate options
97b67c3 
PR-URL: nodejs/node#16339
Fixes: nodejs/node#16332
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Oct 26, 2017
@vsemozhetbyt @addaleax
meta: add note about email sync to CONTRIBUTING.md
542b277 
PR-URL: nodejs/node#16340
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>

Refs: nodejs/node#16339 (comment)
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
@vsemozhetbyt @MylesBorins
meta: add note about email sync to CONTRIBUTING.md
f838b46 
PR-URL: #16340
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>

Refs: #16339 (comment)
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
@vsemozhetbyt @MylesBorins
meta: add note about email sync to CONTRIBUTING.md
72d5af5 
PR-URL: #16340
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>

Refs: #16339 (comment)
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
@vsemozhetbyt @MylesBorins
meta: add note about email sync to CONTRIBUTING.md
b0ac76d 
PR-URL: #16340
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>

Refs: #16339 (comment)
addaleax pushed a commit to ayojs/ayo that referenced this pull request Dec 7, 2017
@addaleax
doc: remove duplicate options
3d33c14 
PR-URL: nodejs/node#16339
Fixes: nodejs/node#16332
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Dec 7, 2017
@vsemozhetbyt @addaleax
meta: add note about email sync to CONTRIBUTING.md
7d29d4a 
PR-URL: nodejs/node#16340
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>

Refs: nodejs/node#16339 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

@hiroppy hiroppy hiroppy approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

Assignees
No one assigned
Labels
child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: child_process.exec() has duplicate options
9 participants
@hyades @vsemozhetbyt @apapirovski @gibfahn @jasnell @cjihrig @hiroppy @MylesBorins @nodejs-github-bot