[backport 6.x] doc: fix types and description for dns.resolveTxt #16316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
dns
silverwind
reviewed
Oct 19, 2017
doc/api/dns.md
Outdated
| @@ -193,7 +193,8 @@ records. The type and structure of individual results varies based on `rrtype`: | |||
| | `'PTR'` | pointer records | {string} | [`dns.resolvePtr()`][] | | |||
| | `'SOA'` | start of authority records | {Object} | [`dns.resolveSoa()`][] | | |||
| | `'SRV'` | service records | {Object} | [`dns.resolveSrv()`][] | | |||
| | `'TXT'` | text records | {string} | [`dns.resolveTxt()`][] | | |||
| | `'TXT'` | text records | {string[]} | [`dns.resolveTxt()`][] | | |||
| | `'ANY'` | any records | {Object} | [`dns.resolveAny()`][] | | |||
There was a problem hiding this comment.
I don't think resolveAny was backported to v6.x, so this line probably has to go.
PR-URL: nodejs#15472 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
tniessen
force-pushed
the
backport-15472-to-v6.x
branch
from
f245ee3
to
2192ed7
Compare
|
@silverwind Thank you, fixed! PTAL |
silverwind
approved these changes
Oct 20, 2017
jasnell
approved these changes
Oct 20, 2017
MylesBorins
pushed a commit
that referenced
this pull request
Oct 25, 2017
Backport-PR-URL: #16316 PR-URL: #15472 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
|
landed in 3293a0c |
MylesBorins
pushed a commit
that referenced
this pull request
Oct 25, 2017
Backport-PR-URL: #16316 PR-URL: #15472 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 26, 2017
Backport-PR-URL: #16316 PR-URL: #15472 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-URL: #15472