Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add apapirovski to collaborators #16302

Closed
wants to merge 1 commit into from
Closed

doc: add apapirovski to collaborators #16302

wants to merge 1 commit into from

Conversation

apapirovski
Copy link
Member

I guess this is happening... 😅

Checklist
Affected core subsystem(s)

doc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 18, 2017
@apapirovski
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/10824/

addaleax
addaleax approved these changes Oct 18, 2017
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’d say “welcome to the club!” but then again I kind of assumed you already were a collaborator for ages :)

jasnell
jasnell approved these changes Oct 18, 2017
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 🎉

apapirovski added a commit to apapirovski/node that referenced this pull request Oct 18, 2017
@apapirovski
doc: add apapirovski to collaborators
0a090d3 
PR-URL: nodejs#16302
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
@apapirovski
Copy link
Member Author

Landed in 0a090d3

@apapirovski apapirovski deleted the add-myself-to-collaborators branch October 18, 2017 20:05
MylesBorins pushed a commit that referenced this pull request Oct 23, 2017
@apapirovski @MylesBorins
doc: add apapirovski to collaborators
7bf9878 
PR-URL: #16302
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
@Trott Trott added the notable-change PRs with changes that should be highlighted in changelogs. label Nov 11, 2017
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
@apapirovski @MylesBorins
doc: add apapirovski to collaborators
3a60a9c 
PR-URL: #16302
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Nov 21, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
@apapirovski @MylesBorins
doc: add apapirovski to collaborators
c66e013 
PR-URL: #16302
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
@apapirovski @MylesBorins
doc: add apapirovski to collaborators
47bf494 
PR-URL: #16302
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@addaleax addaleax addaleax approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. notable-change PRs with changes that should be highlighted in changelogs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@apapirovski @jasnell @Trott @addaleax @vsemozhetbyt @MylesBorins @nodejs-github-bot