Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix flaky test-benchmark-buffer #16296

Closed
wants to merge 1 commit into from
Closed

test: fix flaky test-benchmark-buffer #16296

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Oct 18, 2017

Allow zero operations for short buffer benchmark tests.

Should fix flaky CI as seen in https://ci.nodejs.org/job/node-test-commit-linux/13297/nodes=ubuntu1604-32/console:

    buffers/buffer_zero.js
    /home/iojs/build/workspace/node-test-commit-linux/nodes/ubuntu1604-32/benchmark/common.js:202
          throw new Error('insufficient clock precision for short benchmark');
          ^
    
    Error: insufficient clock precision for short benchmark
        at Benchmark.end (/home/iojs/build/workspace/node-test-commit-linux/nodes/ubuntu1604-32/benchmark/common.js:202:13)
        at main (/home/iojs/build/workspace/node-test-commit-linux/nodes/ubuntu1604-32/benchmark/buffers/buffer_zero.js:22:9)
        at Benchmark.process.nextTick (/home/iojs/build/workspace/node-test-commit-linux/nodes/ubuntu1604-32/benchmark/common.js:34:28)
        at _combinedTickCallback (internal/process/next_tick.js:131:7)
        at process._tickCallback (internal/process/next_tick.js:180:9)
        at Function.Module.runMain (module.js:644:11)
        at startup (bootstrap_node.js:187:16)
        at bootstrap_node.js:605:3
    assert.js:45
      throw new errors.AssertionError({
      ^
    
    AssertionError [ERR_ASSERTION]: 1 === 0
        at ChildProcess.child.on (/home/iojs/build/workspace/node-test-commit-linux/nodes/ubuntu1604-32/test/common/benchmark.js:25:12)
        at emitTwo (events.js:136:13)
        at ChildProcess.emit (events.js:227:7)
        at Process.ChildProcess._handle.onexit (internal/child_process.js:209:12)
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test benchmark buffer

@Trott
test: fix flaky test-benchmark-buffer
6746672 
Allow zero operations for short buffer benchmark tests.
@Trott Trott added benchmark Issues and PRs related to the benchmark subsystem. buffer Issues and PRs related to the buffer subsystem. flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests. labels Oct 18, 2017
@Trott
Copy link
Member Author

Trott commented Oct 18, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/10813/

@Trott
Copy link
Member Author

Trott commented Oct 18, 2017 •
edited
Loading

Landed in 28dcdb9

@Trott Trott closed this Oct 18, 2017
Trott added a commit to Trott/io.js that referenced this pull request Oct 18, 2017
@Trott
test: fix flaky test-benchmark-buffer
28dcdb9 
Allow zero operations for short buffer benchmark tests.

PR-URL: nodejs#16296
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 23, 2017
@Trott @MylesBorins
test: fix flaky test-benchmark-buffer
70dab19 
Allow zero operations for short buffer benchmark tests.

PR-URL: #16296
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Oct 26, 2017
@Trott @addaleax
test: fix flaky test-benchmark-buffer
5d51c99 
Allow zero operations for short buffer benchmark tests.

PR-URL: nodejs/node#16296
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Dec 7, 2017
@Trott @addaleax
test: fix flaky test-benchmark-buffer
d3cb315 
Allow zero operations for short buffer benchmark tests.

PR-URL: nodejs/node#16296
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@Trott Trott deleted the fix-test-benchmark-buffer branch January 13, 2022 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
benchmark Issues and PRs related to the benchmark subsystem. buffer Issues and PRs related to the buffer subsystem. flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Trott @jasnell @cjihrig @MylesBorins