Revert "build: call setlocal in vcbuild.bat" #16270
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
build
2 tasks
|
The commit message and PR description should ideally provide a reason for the revert |
|
Updated OP |
cjihrig
approved these changes
Oct 17, 2017
jasnell
approved these changes
Oct 18, 2017
danbev
approved these changes
Oct 18, 2017
addaleax
approved these changes
Oct 18, 2017
|
@danbev ... no worries at all! |
MylesBorins
approved these changes
Oct 18, 2017
No real rush IMHO. Now we have a PR it's traceable/searchable, and it can be a sort of Canary, to see if anyone else cries out. |
refack
added a commit
that referenced
this pull request
Oct 19, 2017
This reverts commit b9a55a9. PR-URL: #16270 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Myles Borins <[email protected]>
refack
force-pushed
the
revert-b9a55a9
branch
from
4cc04d8
to
c3ae57f
Compare
MylesBorins
pushed a commit
that referenced
this pull request
Oct 23, 2017
This reverts commit b9a55a9. PR-URL: #16270 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Myles Borins <[email protected]>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Oct 26, 2017
This reverts commit b9a55a93c91fb7fd7ac81e182f843f28014179ca. PR-URL: nodejs/node#16270 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Myles Borins <[email protected]>
|
Yes, don't land, since the original PR did land. |
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Dec 7, 2017
This reverts commit b9a55a93c91fb7fd7ac81e182f843f28014179ca. PR-URL: nodejs/node#16270 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Myles Borins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit b9a55a9.
The above commit is
semver-majorand was landed too quickly.vcbuild.batexports multiple environment variables, which is essential for continued build steps. Disabling this setup issemver-majoras it will break embedders workflows, and breaks developers tools.Besides the semverity this behaviour was discussed several times in the past, and it was decided that it should stay as is.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
build,windows