Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: check uv_prepare_stop return value #16268

Closed
wants to merge 1 commit into from
Closed

src: check uv_prepare_stop return value #16268

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Oct 17, 2017 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src/http2

CI: https://ci.nodejs.org/job/node-test-commit/13235/

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v4.x http2 Issues or PRs related to the http2 subsystem. labels Oct 17, 2017
bnoordhuis
bnoordhuis approved these changes Oct 18, 2017
View reviewed changes
Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. uv_prepare_stop() is infallible though, practically speaking, but the extra check won't hurt.

@addaleax
Copy link
Member Author

Landed in bf1bace

@addaleax addaleax closed this Oct 19, 2017
@addaleax addaleax deleted the http2-prep-stop-check branch October 19, 2017 17:08
addaleax added a commit that referenced this pull request Oct 19, 2017
@addaleax
src: check uv_prepare_stop return value
bf1bace 
PR-URL: #16268
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 23, 2017
@addaleax @MylesBorins
src: check uv_prepare_stop return value
0ddb00d 
PR-URL: #16268
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
addaleax added a commit to ayojs/ayo that referenced this pull request Oct 26, 2017
@addaleax
src: check uv_prepare_stop return value
afc34a8 
PR-URL: nodejs/node#16268
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
addaleax added a commit to ayojs/ayo that referenced this pull request Dec 7, 2017
@addaleax
src: check uv_prepare_stop return value
1173d25 
PR-URL: nodejs/node#16268
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@addaleax @bnoordhuis @jasnell @cjihrig @nodejs-github-bot