Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: Use V8 function to get Module Namespace #16261

Closed
wants to merge 3 commits into from
Closed

src: Use V8 function to get Module Namespace #16261

wants to merge 3 commits into from

Conversation

bmeck
Copy link
Member

@bmeck bmeck commented Oct 17, 2017 •
edited
Loading

Newer V8 does this for us without an intermediate Module Record.

Checklist
Affected core subsystem(s)

src, module

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Oct 17, 2017
addaleax
addaleax approved these changes Oct 17, 2017
View reviewed changes
src/module_wrap.cc Outdated
void ModuleWrap::Namespace(const FunctionCallbackInfo<Value>& args) {
auto iso = args.GetIsolate();
auto that = args.This();
ModuleWrap* obj = Unwrap<ModuleWrap>(that);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you CHECK_NE(obj, nullptr);?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

src/module_wrap.cc Outdated
@@ -207,6 +207,14 @@ void ModuleWrap::Evaluate(const FunctionCallbackInfo<Value>& args) {
args.GetReturnValue().Set(ret);
}

void ModuleWrap::Namespace(const FunctionCallbackInfo<Value>& args) {
auto iso = args.GetIsolate();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style nit: isolate

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

src/module_wrap.cc
@@ -516,6 +524,7 @@ void ModuleWrap::Initialize(Local<Object> target,
env->SetProtoMethod(tpl, "link", Link);
env->SetProtoMethod(tpl, "instantiate", Instantiate);
env->SetProtoMethod(tpl, "evaluate", Evaluate);
env->SetProtoMethod(tpl, "namespace", Namespace);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getNamespace & GetNamespace? At least if this is idempotent I think that’d be a better name

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it can throw if it isn't instantiated.

bnoordhuis
bnoordhuis reviewed Oct 17, 2017
View reviewed changes
lib/internal/loader/Loader.js Outdated
@@ -3,7 +3,6 @@
const { getURLFromFilePath } = require('internal/url');

const {
getNamespaceOfModuleWrap,
createDynamicModule
} = require('internal/loader/ModuleWrap');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could fit this on one line now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

src/module_wrap.cc Outdated
auto iso = args.GetIsolate();
auto that = args.This();
ModuleWrap* obj = Unwrap<ModuleWrap>(that);
auto result = obj->module_.Get(iso)->GetModuleNamespace();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GetModuleNamespace() terminates with a fatal error when GetStatus() isn't one of kInstantiated, kEvaluating or kEvaluated.

I believe I understand how the previous code enforced that invariant (by calling .instantiate() and .evaluate(), right?) but what ensures that now?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nothing except when it is called, can add a check and throw though.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made it throw after checking status

bnoordhuis
bnoordhuis approved these changes Oct 18, 2017
View reviewed changes
Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo style nit.

src/module_wrap.cc Outdated

switch (module->GetStatus()) {
default:
return env->ThrowError("cannot get namespace, Module has not been instantiated");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Long line. Didn't make lint or make test complain about that?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i didn't see one. fixed.

@bmeck bmeck mentioned this pull request Oct 19, 2017
Closed
@targos
Copy link
Member

targos commented Oct 22, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/10892/

@addaleax addaleax added the esm Issues and PRs related to the ECMAScript Modules implementation. label Oct 28, 2017
@addaleax
Copy link
Member

Landed in 1c07724

@addaleax addaleax closed this Oct 28, 2017
addaleax pushed a commit that referenced this pull request Oct 28, 2017
@bmeck @addaleax
src: use V8 function to get Module Namespace
1c07724 
PR-URL: #16261
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@jasnell jasnell mentioned this pull request Oct 30, 2017
Merged
gibfahn pushed a commit that referenced this pull request Oct 30, 2017
@bmeck @gibfahn
src: use V8 function to get Module Namespace
ba023b4 
PR-URL: #16261
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
gibfahn pushed a commit that referenced this pull request Oct 30, 2017
@bmeck @gibfahn
src: use V8 function to get Module Namespace
d89dbcb 
PR-URL: #16261
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
gibfahn pushed a commit that referenced this pull request Oct 31, 2017
@bmeck @gibfahn
src: use V8 function to get Module Namespace
ec51688 
PR-URL: #16261
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@gibfahn gibfahn mentioned this pull request Oct 31, 2017
Merged
Qard pushed a commit to ayojs/ayo that referenced this pull request Nov 2, 2017
@bmeck @Qard
src: use V8 function to get Module Namespace
efebe7c 
PR-URL: nodejs/node#16261
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Qard pushed a commit to ayojs/ayo that referenced this pull request Nov 2, 2017
@bmeck @Qard
src: use V8 function to get Module Namespace
d06f8e9 
PR-URL: nodejs/node#16261
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Dec 7, 2017
@bmeck @addaleax
src: use V8 function to get Module Namespace
16bfd1f 
PR-URL: nodejs/node#16261
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos targos approved these changes

@benjamingr benjamingr benjamingr approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. esm Issues and PRs related to the ECMAScript Modules implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@bmeck @targos @addaleax @bnoordhuis @jasnell @benjamingr @MylesBorins @nodejs-github-bot