src: fix NODE_DEPRECATED macro with old compilers #1626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @misterdjules |
|
lgtm, I think, perhaps R=@koopa |
|
I'd like to see the |
mscdex
added
build
The `__attribute__((deprecated("warning")))` macro didn't exist until
gcc 4.5 and clang 2.9.
While io.js does not build with compilers that old, add-ons do. Let's
make src/node.h compatible with such compilers, it's a public header.
PR-URL: nodejs#1626
Refs: nodejs#1619
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Trevor Norris <[email protected]>
bnoordhuis
force-pushed
the
fix-deprecation-macro
branch
from
347f4b2
to
b712af7
Compare
|
Two LGTMs should be enough, right? Landed with style adjustments in b712af7, thanks for the review. |
|
awesome. thanks. |
Fishrock123
pushed a commit
to Fishrock123/node
that referenced
this pull request
May 19, 2015
The `__attribute__((deprecated("warning")))` macro didn't exist until
gcc 4.5 and clang 2.9.
While io.js does not build with compilers that old, add-ons do. Let's
make src/node.h compatible with such compilers, it's a public header.
PR-URL: nodejs#1626
Refs: nodejs#1619
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Trevor Norris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
__attribute__((deprecated("warning")))macro didn't exist untilgcc 4.5 and clang 2.9.
While io.js does not build with compilers that old, add-ons do. Let's
make src/node.h compatible with such compilers, it's a public header.
Refs: #1619
R=@trevnorris?