test: http2 emitGoAway post shutdown pre destroy #16215
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit tests use case when emitGoAway is called when client is shutting down but is not destroyed Refs: nodejs#14985
jasnell
approved these changes
Oct 15, 2017
cjihrig
approved these changes
Oct 15, 2017
|
Failures in CI look unrelated. |
|
Landed as d64e94b. |
mcollina
pushed a commit
that referenced
this pull request
Oct 17, 2017
This commit tests use case when emitGoAway is called when client is shutting down but is not destroyed. Refs: #14985 PR-URL: #16215 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Oct 18, 2017
This commit tests use case when emitGoAway is called when client is shutting down but is not destroyed. Refs: nodejs/node#14985 PR-URL: nodejs/node#16215 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 23, 2017
This commit tests use case when emitGoAway is called when client is shutting down but is not destroyed. Refs: #14985 PR-URL: #16215 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit tests use case when emitGoAway is called when client is
shutting down but is not destroyed
node/lib/internal/http2/core.js
Lines 368 to 370 in 411695e
Refs: #14985
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test, http2