Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Update a typo in module.js' comments #16205

Closed
wants to merge 1 commit into from
Closed

Docs: Update a typo in module.js' comments #16205

wants to merge 1 commit into from

Conversation

orta
Copy link
Contributor

@orta orta commented Oct 14, 2017

Updates a comment's english

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

Module

@nodejs-github-bot nodejs-github-bot added the module Issues and PRs related to the module subsystem. label Oct 14, 2017
@joyeecheung
Copy link
Member

CI because it touches lib: https://ci.nodejs.org/job/node-test-pull-request/10721/

@joyeecheung
Copy link
Member

Landed in 520cf1d, thanks for the contribution!

joyeecheung pushed a commit that referenced this pull request Oct 15, 2017
@orta @joyeecheung
doc: Update a typo in module.js' comments
520cf1d 
PR-URL: #16205
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Oct 15, 2017
@orta @addaleax
doc: Update a typo in module.js' comments
4a30c69 
PR-URL: nodejs/node#16205
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
targos pushed a commit that referenced this pull request Oct 18, 2017
@orta @targos
doc: Update a typo in module.js' comments
d75a403 
PR-URL: #16205
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
@orta @MylesBorins
doc: Update a typo in module.js' comments
63b6cc3 
PR-URL: #16205
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Nov 21, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
@orta @MylesBorins
doc: Update a typo in module.js' comments
fde70db 
PR-URL: #16205
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
@orta @MylesBorins
doc: Update a typo in module.js' comments
1fdcf75 
PR-URL: #16205
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyeecheung joyeecheung joyeecheung approved these changes

@hiroppy hiroppy hiroppy approved these changes

@tniessen tniessen tniessen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@watilde watilde watilde approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
module Issues and PRs related to the module subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@orta @joyeecheung @lpinca @watilde @cjihrig @tniessen @hiroppy @MylesBorins @nodejs-github-bot