Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: update to ESLint 4.8.0 #16199

Closed
wants to merge 2 commits into from
Closed

tools: update to ESLint 4.8.0 #16199

wants to merge 2 commits into from

Conversation

apapirovski
Copy link
Member

The first commit addresses an extraneous space in lib/modules.js which seems to go unnoticed in v4.3.0 of eslint but gets flagged by v4.8.0. The second commit upgrades to [email protected]. This mimics the PRs for 4.2.0 & 4.3.0 upgrades.

Here's the changelog: https://github.com/eslint/eslint/blob/master/CHANGELOG.md (Quite a few bug fixes & also some perf changes so I figured it was worth upgrading)

/cc @Trott (since you did the 4.2.0 & 4.3.0 updates)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

lib, tools

@apapirovski
lib: fix extraneous space in module.js
a1afb6d 
An extra space was not caught by the linter due to what appears
to be a bug in eslint 4.3.0 — remove it.
@nodejs-github-bot nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Oct 14, 2017
Trott
Trott previously requested changes Oct 14, 2017
View reviewed changes
Copy link
Member

@Trott Trott left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes about twice as many files as I would expect. Was ESLint updated using tools/update-eslint.sh? If not, can you remove the commit that updates ESLint and use that instead? (And yes, that's probably not documented anywhere and should be.)

@apapirovski
Copy link
Member Author

apapirovski commented Oct 14, 2017 •
edited
Loading

@Trott fixed now. Thanks!

(This will teach me not to make a PR jet-lagged on a Friday night. 😂 I even knew that script was there.)

@Trott Trott dismissed their stale review October 14, 2017 21:28

Still seems to update about 70 more files than I get when I do it locally, but I suppose that might be due to different versions of npm or something like that...

@apapirovski
Copy link
Member Author

apapirovski commented Oct 14, 2017 •
edited
Loading

@Trott I get 497 (16 more) now but eslint just released 4.9.0 so that's probably the reason for the difference. I'm using npm@latest & dmn@latest. Could be a difference in dmn version maybe? I could see that making a difference...

@not-an-aardvark
Copy link
Contributor

The difference in changed-file count might be due to updated package.json metadata, which would change depending on the absolute path where a module is installed.

@apapirovski
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/10830/

apapirovski added a commit to apapirovski/node that referenced this pull request Oct 19, 2017
@apapirovski
lib: fix extraneous space in module.js
10ef563 
An extra space was not caught by the linter due to what appears
to be a bug in eslint 4.3.0 — remove it.

PR-URL: nodejs#16199
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
apapirovski added a commit to apapirovski/node that referenced this pull request Oct 19, 2017
@apapirovski
tools: update to ESLint 4.8.0
7babce9 
PR-URL: nodejs#16199
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@apapirovski
Copy link
Member Author

Landed in 10ef563 and 7babce9

@apapirovski apapirovski deleted the patch-eslint-upgrade branch October 19, 2017 13:04
MylesBorins pushed a commit that referenced this pull request Oct 23, 2017
@apapirovski @MylesBorins
lib: fix extraneous space in module.js
ec93a53 
An extra space was not caught by the linter due to what appears
to be a bug in eslint 4.3.0 — remove it.

PR-URL: #16199
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 23, 2017
@apapirovski @MylesBorins
tools: update to ESLint 4.8.0
37b5035 
PR-URL: #16199
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Oct 26, 2017
@apapirovski @addaleax
lib: fix extraneous space in module.js
40eaf17 
An extra space was not caught by the linter due to what appears
to be a bug in eslint 4.3.0 — remove it.

PR-URL: nodejs/node#16199
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Oct 26, 2017
@apapirovski @addaleax
tools: update to ESLint 4.8.0
ced86c8 
PR-URL: nodejs/node#16199
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@MylesBorins
Copy link
Contributor

This is going to need to be backported to v6.x

Most likely it will make sense to simply update the 6.x branch directly and label this one don't land

addaleax pushed a commit to ayojs/ayo that referenced this pull request Dec 7, 2017
@apapirovski @addaleax
lib: fix extraneous space in module.js
d21c5eb 
An extra space was not caught by the linter due to what appears
to be a bug in eslint 4.3.0 — remove it.

PR-URL: nodejs/node#16199
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Dec 7, 2017
@apapirovski @addaleax
tools: update to ESLint 4.8.0
20985a3 
PR-URL: nodejs/node#16199
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

@hiroppy hiroppy hiroppy approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@Trott Trott Trott left review comments

Assignees
No one assigned
Labels
lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@apapirovski @not-an-aardvark @MylesBorins @jasnell @Trott @cjihrig @hiroppy @BridgeAR @nodejs-github-bot