Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add UV_THREADPOOL_SIZE link definition #16193

Closed
wants to merge 1 commit into from

Conversation

maclover7
Copy link
Contributor

Currently is rendered as "see the [UV_THREADPOOL_SIZE][] documentation",

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Currently is rendered as "see the [UV_THREADPOOL_SIZE][] documentation",
since there was no link definition in the file.
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. zlib Issues and PRs related to the zlib subsystem. labels Oct 13, 2017
Copy link
Member

@joyeecheung joyeecheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this needs 48 hours to land

@joyeecheung
Copy link
Member

Landed in 0ff0c70, thanks!

joyeecheung pushed a commit that referenced this pull request Oct 14, 2017
Currently is rendered as "see the [UV_THREADPOOL_SIZE][]
documentation", since there was no link definition in the file.

PR-URL: #16193
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
@maclover7 maclover7 deleted the jm-uvtp-doc branch October 14, 2017 13:53
addaleax pushed a commit to ayojs/ayo that referenced this pull request Oct 15, 2017
Currently is rendered as "see the [UV_THREADPOOL_SIZE][]
documentation", since there was no link definition in the file.

PR-URL: nodejs/node#16193
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
targos pushed a commit that referenced this pull request Oct 18, 2017
Currently is rendered as "see the [UV_THREADPOOL_SIZE][]
documentation", since there was no link definition in the file.

PR-URL: #16193
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. zlib Issues and PRs related to the zlib subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants