Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: rename good first contrib label #16150

Closed
wants to merge 1 commit into from
Closed

doc: rename good first contrib label #16150

wants to merge 1 commit into from

Conversation

Fishrock123
Copy link
Contributor

Now good first issue.

Refs: #16149

@Fishrock123 Fishrock123 added the doc Issues and PRs related to the documentations. label Oct 11, 2017
joyeecheung
joyeecheung approved these changes Oct 12, 2017
View reviewed changes
Copy link
Member

@joyeecheung joyeecheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could skip the 48-hour wait on this

@watilde
Copy link
Member

watilde commented Oct 12, 2017

Landed in 21ca1d3.

@watilde watilde closed this Oct 12, 2017
watilde pushed a commit that referenced this pull request Oct 12, 2017
@Fishrock123 @watilde
doc: rename good first contrib label
21ca1d3 
Now `good first issue`.

PR-URL: #16150
Refs: #16149
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Oct 15, 2017
@Fishrock123 @addaleax
doc: rename good first contrib label
d82f272 
Now `good first issue`.

PR-URL: nodejs/node#16150
Refs: nodejs/node#16149
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
targos pushed a commit that referenced this pull request Oct 18, 2017
@Fishrock123 @targos
doc: rename good first contrib label
f2146d0 
Now `good first issue`.

PR-URL: #16150
Refs: #16149
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
targos pushed a commit that referenced this pull request Oct 18, 2017
@Fishrock123 @targos
doc: rename good first contrib label
e375b8c 
Now `good first issue`.

PR-URL: #16150
Refs: #16149
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
@Fishrock123 Fishrock123 deleted the doc-good-first-issue-label branch October 18, 2017 23:04
MylesBorins pushed a commit that referenced this pull request Nov 15, 2017
@Fishrock123 @MylesBorins
doc: rename good first contrib label
df858d7 
Now `good first issue`.

PR-URL: #16150
Refs: #16149
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Nov 21, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
@Fishrock123 @MylesBorins
doc: rename good first contrib label
4c7ac0b 
Now `good first issue`.

PR-URL: #16150
Refs: #16149
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
@Fishrock123 @MylesBorins
doc: rename good first contrib label
04d5835 
Now `good first issue`.

PR-URL: #16150
Refs: #16149
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danbev danbev danbev approved these changes

@addaleax addaleax addaleax approved these changes

@watilde watilde watilde approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@hiroppy hiroppy hiroppy approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@Fishrock123 @watilde @danbev @addaleax @targos @cjihrig @hiroppy @joyeecheung @MylesBorins