Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

n-api,test: use module name macro #16146

Closed

Conversation

gabrielschulhof
Copy link
Contributor

test_constructor_name.c should use NODE_GYP_MODULE_NAME.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

n-api,test

test_constructor_name.c should use NODE_GYP_MODULE_NAME.
@nodejs-github-bot nodejs-github-bot added dont-land-on-v4.x node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests. labels Oct 11, 2017
Copy link
Contributor

@evanlucas evanlucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although this probably applies to other tests as well.

@gabrielschulhof
Copy link
Contributor Author

@mhdawson you're right. There are two more in test/addons-napi/test_warning.

@gabrielschulhof
Copy link
Contributor Author

Landed in 17b818b.

gabrielschulhof pushed a commit that referenced this pull request Oct 13, 2017
test_constructor_name.c should use NODE_GYP_MODULE_NAME.

PR-URL: #16146
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Oct 15, 2017
test_constructor_name.c should use NODE_GYP_MODULE_NAME.

PR-URL: nodejs/node#16146
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
targos pushed a commit that referenced this pull request Oct 18, 2017
test_constructor_name.c should use NODE_GYP_MODULE_NAME.

PR-URL: #16146
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Apr 16, 2018
test_constructor_name.c should use NODE_GYP_MODULE_NAME.

PR-URL: nodejs#16146
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 16, 2018
test_constructor_name.c should use NODE_GYP_MODULE_NAME.

Backport-PR-URL: #19447
PR-URL: #16146
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Apr 16, 2018
@gabrielschulhof gabrielschulhof deleted the update-module-name branch April 30, 2018 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants