win, test: escape script filename on Windows #16124
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Escape backslashes in script filename on Windows in a CLI test. Fixes: nodejs#16057 Fixes: nodejs#16023
watilde
approved these changes
Oct 10, 2017
mscdex
added
the
cli
Qard
approved these changes
Oct 11, 2017
jasnell
approved these changes
Oct 12, 2017
digitalinfinity
approved these changes
Oct 13, 2017
jasnell
pushed a commit
that referenced
this pull request
Oct 13, 2017
Escape backslashes in script filename on Windows in a CLI test. PR-URL: #16124 Fixes: #16057 and #16023 Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in 07ec10d |
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Oct 15, 2017
Escape backslashes in script filename on Windows in a CLI test. PR-URL: nodejs/node#16124 Fixes: nodejs/node#16057 and #16023 Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
that referenced
this pull request
Oct 18, 2017
Escape backslashes in script filename on Windows in a CLI test. PR-URL: #16124 Fixes: #16057 and #16023 Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 16, 2017
Escape backslashes in script filename on Windows in a CLI test. PR-URL: #16124 Fixes: #16057 and #16023 Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 21, 2017
Escape backslashes in script filename on Windows in a CLI test. PR-URL: #16124 Fixes: #16057 and #16023 Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 28, 2017
Escape backslashes in script filename on Windows in a CLI test. PR-URL: #16124 Fixes: #16057 and #16023 Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Escape backslashes in script filename on Windows in
test-cli-eval.js.Fixes: #16057 and #16023
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test