Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add tests for ERR_HTTP2_FRAME_ERROR #16107

Closed
wants to merge 1 commit into from
Closed

test: add tests for ERR_HTTP2_FRAME_ERROR #16107

wants to merge 1 commit into from

Conversation

ruxandrafed
Copy link
Contributor

@ruxandrafed ruxandrafed commented Oct 9, 2017 •
edited
Loading

This should finally bring the coverage to 100% for branches, too 😄

internal/errors coverage

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 9, 2017
@ruxandrafed ruxandrafed mentioned this pull request Oct 9, 2017
Closed
3 tasks
@gibfahn
Copy link
Member

gibfahn commented Oct 9, 2017

CI: https://ci.nodejs.org/job/node-test-commit/12953/

@mscdex mscdex added the http2 Issues or PRs related to the http2 subsystem. label Oct 10, 2017
@joyeecheung
Copy link
Member

Landed in e308761, thanks!

joyeecheung pushed a commit that referenced this pull request Oct 15, 2017
@ruxandrafed @joyeecheung
test: add tests for ERR_HTTP2_FRAME_ERROR
e308761 
PR-URL: #16107
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Oct 15, 2017
@ruxandrafed @addaleax
test: add tests for ERR_HTTP2_FRAME_ERROR
67253b3 
PR-URL: nodejs/node#16107
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 23, 2017
@ruxandrafed @MylesBorins
test: add tests for ERR_HTTP2_FRAME_ERROR
6ad5b90 
PR-URL: #16107
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@watilde watilde watilde approved these changes

@hiroppy hiroppy hiroppy approved these changes

@gibfahn gibfahn gibfahn approved these changes

Assignees
No one assigned
Labels
http2 Issues or PRs related to the http2 subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@ruxandrafed @gibfahn @joyeecheung @jasnell @watilde @hiroppy @mscdex @MylesBorins @nodejs-github-bot