Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: improve crypto HMAC test assertions #16026

Closed
wants to merge 1 commit into from
Closed

test: improve crypto HMAC test assertions #16026

wants to merge 1 commit into from

Conversation

sholladay
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 6, 2017
@sholladay
test: improve crypto HMAC test assertions
dd478fc 
Fixes argument order for assertions and makes their failure messages more descriptive and easier to debug.
@sholladay sholladay changed the title improve crypto HMAC test assertions test: improve crypto HMAC test assertions Oct 6, 2017
@mscdex mscdex added the crypto Issues and PRs related to the crypto subsystem. label Oct 6, 2017
BridgeAR
BridgeAR approved these changes Oct 6, 2017
View reviewed changes
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green

@Trott Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 7, 2017
@lance lance self-assigned this Oct 9, 2017
@lance
Copy link
Member

lance commented Oct 9, 2017 •
edited
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/10546/

Edit
CI is green (and complete) but remains pending in GitHub. Landing this.

@lance
Copy link
Member

lance commented Oct 9, 2017

Landed in: fe38ace

@sholladay thank you for your contribution! It's much appreciated.

@lance lance closed this Oct 9, 2017
lance pushed a commit that referenced this pull request Oct 9, 2017
@sholladay @lance
test: improve crypto HMAC test assertions
fe38ace 
Fixes argument order for assertions and makes their failure messages
more descriptive and easier to debug.

PR-URL: #16026
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Lance Ball <[email protected]>
addaleax pushed a commit to addaleax/ayo that referenced this pull request Oct 12, 2017
@sholladay @addaleax
test: improve crypto HMAC test assertions
7de4934 
Fixes argument order for assertions and makes their failure messages
more descriptive and easier to debug.

PR-URL: nodejs/node#16026
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Lance Ball <[email protected]>
targos pushed a commit that referenced this pull request Oct 18, 2017
@sholladay @targos
test: improve crypto HMAC test assertions
1be3f50 
Fixes argument order for assertions and makes their failure messages
more descriptive and easier to debug.

PR-URL: #16026
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Lance Ball <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance lance lance approved these changes

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees

@lance lance

Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. crypto Issues and PRs related to the crypto subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@sholladay @lance @addaleax @cjihrig @BridgeAR @mscdex @MylesBorins @Trott @nodejs-github-bot