test: added a test comment #16003
test: added a test comment #16003
Conversation
Trott
added
the
code-and-learn
earobinson
force-pushed
the
earobinson/update-test-debugger-debug-brk-to-use-propper-common-utils
branch
from
92ef77a
to
895e8c6
Compare
|
This doesn't seem to be about migrating string concatenations anymore after the update. It's more about adding a comment explaining what this test does now? |
|
@joyeecheung I would agree, would you suggest I rebase and update the comment or just edit the pr description? |
| const fixtures = require('../common/fixtures'); | ||
|
|
||
| // This test ensures that the debug-brk flag will spin up a new process and | ||
| // wait, aka not quit. |
There was a problem hiding this comment.
Micro-nit that you can ignore if you wish: aka not quit may be a bit unclear to people unfamiliar with a.k.a. Might be better as ...and wait, rather than exit.
@earobinson I'd say update both if it's not a hassle for you. (Whoever lands the commit can update the commit message, but you'd be saving them a bit of work if you do it yourself, plus that eliminates the possibility that they'll forget to do it.) |
Added comments to the tests to better describe what the test is doing.
earobinson
force-pushed
the
earobinson/update-test-debugger-debug-brk-to-use-propper-common-utils
branch
from
895e8c6
to
c912eaa
Compare
earobinson
changed the title
|
@Trott rebased, and updated the pr. |
|
Landed in 7205e0a |
Added comments to the tests to better describe what the test is doing. PR-URL: nodejs#16003 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
earobinson
deleted the
earobinson/update-test-debugger-debug-brk-to-use-propper-common-utils
branch
Added comments to the tests to better describe what the test is doing. PR-URL: nodejs/node#16003 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
Added comments to the tests to better describe what the test is doing. PR-URL: #16003 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
Added comments to the tests to better describe what the test is doing. PR-URL: #16003 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
Added comments to the tests to better describe what the test is doing.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
tests