Replaced common.fixturesDir with common/fixtures module in test/es-module/test-esm-encoded-path-native.js #15989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscdex
added
the
esm
Trott
added
the
code-and-learn
BridgeAR
reviewed
Oct 6, 2017
| @@ -1,5 +1,5 @@ | |||
| 'use strict'; | |||
| const common = require('../common'); | |||
| const common = require('../common/fixtures'); | |||
There was a problem hiding this comment.
Did this test ever work? It seems like it did not? common itself should still be required as it is going to load a couple of other things as well. The return value here should also be renamed to fixtures, since it is not common that is returned here anymore.
|
@hschwalm do you still want to pursue this? |
…dule/test-esm-encoded-path-native.js
joyeecheung
approved these changes
Oct 16, 2017
cjihrig
approved these changes
Oct 16, 2017
jasnell
reviewed
Oct 16, 2017
| const assert = require('assert'); | ||
| const { spawn } = require('child_process'); | ||
|
|
||
| const native = `${common.fixturesDir}/es-module-url/native.mjs`; | ||
| const native = `${fixtures.fixturesDir}/es-module-url/native.mjs`; |
There was a problem hiding this comment.
This can be simply:
const native = fixtures.path('es-module-url', 'native.mjs');
|
Landed in b932854 with #15989 (review) fixed. Thanks for the contribution! |
joyeecheung
pushed a commit
that referenced
this pull request
Oct 16, 2017
PR-URL: #15989 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
targos
pushed a commit
that referenced
this pull request
Oct 18, 2017
PR-URL: #15989 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Oct 18, 2017
PR-URL: nodejs/node#15989 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the common.fixturesDir with the usage of common/fixtures module
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)