test: include value to assert message

[hwaisiu]

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

Affected core subsystem(s)

[BridgeAR]

The more important part is actually what result.toString() looks like. Please change it to something like

`${result.toString()} should equal ${abc + def}`

[hwaisiu]

Hi Ruben Thanks for the comment I have modified the code and checked in. This is my first time contributing to Node. Please let me know if I missed any steps. ThanksHazel Sent from my Samsung Galaxy smartphone. -------- Original message --------From: Ruben Bridgewater <[email protected]> Date: 10/7/17 10:47 AM (GMT-08:00) To: nodejs/node <[email protected]> Cc: hwaisiu <[email protected]>, Author <[email protected]> Subject: Re: [nodejs/node] test: include value to assert message (#15970) @BridgeAR commented on this pull request. In test/parallel/test-zlib-from-concatenated-gzip.js:

@@ -20,13 +23,13 @@ assert.strictEqual(zlib.gunzipSync(data).toString(), 'abcdef');

zlib.gunzip(data, common.mustCall((err, result) => { assert.ifError(err); assert.strictEqual(result.toString(), 'abcdef', - 'result should match original string'); + 'result should match original string: ' + (abc + def)); The more important part is actually what result.toString() looks like. Please change it to something like `${result.toString()} should equal ${abc + def}` — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread. {"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/nodejs/node","title":"nodejs/node","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/nodejs/node"}},"updates":{"snippets":[{"icon":"PERSON","message":"@BridgeAR commented on #15970"}],"action":{"name":"View Pull Request","url":"#15970 (review)"}}}

[joyeecheung]

@hwaisiu Hi, have you pushed your changes to your branch (hwaisiu:node-dev)? The workflow should be something like:

$ git checkout node-dev # or other branch name that you have in your local repo that points to this PR
# make changes
$ git commit --amend # You can leave the commit message as-is in the editor
$ git push --force hwaisiu node-dev # assuming "hwaisiu" is pointing to your forked repository

[jasnell]

LGTM with @BridgeAR's suggestion

[hwaisiu]

I got a 403 error after I entered:
$ git push --force

[hwaisiu]

I think I have figured out how to push the changes.
Could you please review my updated changes?

Thanks

[joyeecheung]

I think this is actually more readable if the assertion message is removed.

[BridgeAR]

Just a note for a potential next PR - the commit messages do not follow the guidelines.

[BridgeAR]

Landed in ef96b05

Thanks for the PR, and congratulations on becoming a Node.js Contributor 🎉 !