Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replaced common.fixturesDir with usage of the common.fixtures module. #15961

Closed
wants to merge 3 commits into from
Closed

replaced common.fixturesDir with usage of the common.fixtures module. #15961

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d05fe78
replaced common.fixturesDir with usage of the common.fixtures module.
BinarySo1o Oct 6, 2017
fe9a09b
test: corrected dgram send callback multi buffer on error condition
BinarySo1o Oct 6, 2017
6969c75
Update test-dgram-send-callback-multi-buffer.js
BinarySo1o Oct 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion test/parallel/test-npm-install.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,10 @@ const npmPath = path.join(
'npm-cli.js'
);

const fixtures = require('../common/fixtures');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit - it would be nice to move the require up to the other require calls.

const pkgContent = JSON.stringify({
dependencies: {
'package-name': `${common.fixturesDir}/packages/main`
'package-name': fixtures.path('packages/main')
}
});

Expand Down