Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing template literal #15953

Closed
wants to merge 1 commit into from
Closed

Removing template literal #15953

wants to merge 1 commit into from

Conversation

emilyford352
Copy link

@emilyford352 emilyford352 commented Oct 6, 2017 •
edited by BridgeAR
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added dont-land-on-v4.x node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests. labels Oct 6, 2017
@Trott Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 6, 2017
@BridgeAR
Copy link
Member

BridgeAR commented Oct 7, 2017

The commit message should be changed to include the subsystem. This can be added while landing.

@joyeecheung
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/10477/

@BridgeAR BridgeAR self-assigned this Oct 8, 2017
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Oct 8, 2017
@emilyford @BridgeAR
test: remove template literal
e6e58fd 
PR-URL: nodejs#15953
Reviewed-By: Ruben Bridgewater <[email protected]>
@BridgeAR
Copy link
Member

BridgeAR commented Oct 8, 2017

Landed in e6e58fd

Thanks for the PR, and congratulations on becoming a Node.js Contributor 🎉 !

@BridgeAR BridgeAR closed this Oct 8, 2017
MylesBorins pushed a commit that referenced this pull request Oct 11, 2017
@emilyford @MylesBorins
test: remove template literal
9059b09 
PR-URL: #15953
Reviewed-By: Ruben Bridgewater <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Oct 11, 2017
Merged
addaleax pushed a commit to addaleax/ayo that referenced this pull request Oct 12, 2017
@emilyford @addaleax
test: remove template literal
423926a 
PR-URL: nodejs/node#15953
Reviewed-By: Ruben Bridgewater <[email protected]>
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Apr 16, 2018
@emilyford
test: remove template literal
1b2c2a9 
PR-URL: nodejs#15953
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 16, 2018
@emilyford @MylesBorins
test: remove template literal
37acd80 
Backport-PR-URL: #19447
PR-URL: #15953
Reviewed-By: Ruben Bridgewater <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Apr 16, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees

@BridgeAR BridgeAR

Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@emilyford352 @BridgeAR @joyeecheung @Trott @nodejs-github-bot @emilyford