Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: replaced common.fixturesDir with common.fixtures module usage #15933

Closed
wants to merge 4 commits into from
Closed

test: replaced common.fixturesDir with common.fixtures module usage #15933

wants to merge 4 commits into from

Conversation

letthewookieewin
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 6, 2017
pawelgolda
pawelgolda reviewed Oct 6, 2017
View reviewed changes
test/parallel/test-https-client-get-url.js Outdated
@@ -35,8 +36,8 @@ const url = require('url');
const URL = url.URL;

const options = {
key: fs.readFileSync(`${common.fixturesDir}/keys/agent1-key.pem`),
cert: fs.readFileSync(`${common.fixturesDir}/keys/agent1-cert.pem`)
key: fs.readFileSync(`${fixtures.fixturesDir}/keys/agent1-key.pem`),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be using method fixtures.readKey instead of fs.readFileSync to get the keys.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

D'oh! Updated to use fixtures.readKey and fixtures.readSync (for the cert).

@letthewookieewin
Copy link
Contributor Author

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@mscdex mscdex added the https Issues or PRs related to the https subsystem. label Oct 6, 2017
@Trott Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 7, 2017
@joyeecheung
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/10491/

@gibfahn gibfahn self-assigned this Oct 8, 2017
@gibfahn
Copy link
Member

gibfahn commented Oct 8, 2017

Landed in b050c14

Thanks for the PR, and congratulations on becoming a Node.js Contributor 🎉 !

@gibfahn gibfahn closed this Oct 8, 2017
gibfahn pushed a commit that referenced this pull request Oct 8, 2017
@letthewookieewin @gibfahn
test: replaced common.fixturesDir with readKey
b050c14 
PR-URL: #15933
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
@letthewookieewin
Copy link
Contributor Author

Thanks @joyeecheung @danbev @cjihrig @tniessen, and special thanks to @gibfahn for the help at the conference with this. Now, on to my next contribution!

MylesBorins pushed a commit that referenced this pull request Oct 11, 2017
@letthewookieewin @MylesBorins
test: replaced common.fixturesDir with readKey
e9d31bc 
PR-URL: #15933
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Oct 11, 2017
Merged
addaleax pushed a commit to addaleax/ayo that referenced this pull request Oct 12, 2017
@letthewookieewin @addaleax
test: replaced common.fixturesDir with readKey
c2e90ed 
PR-URL: nodejs/node#15933
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 14, 2017
@letthewookieewin @MylesBorins
test: replaced common.fixturesDir with readKey
4021c12 
PR-URL: #15933
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Nov 21, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
@letthewookieewin @MylesBorins
test: replaced common.fixturesDir with readKey
fbe0b3e 
PR-URL: #15933
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
@letthewookieewin @MylesBorins
test: replaced common.fixturesDir with readKey
000965d 
PR-URL: #15933
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawelgolda pawelgolda pawelgolda left review comments

@danbev danbev danbev approved these changes

@cjihrig cjihrig cjihrig approved these changes

@tniessen tniessen tniessen approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@gibfahn gibfahn gibfahn approved these changes

Assignees

@gibfahn gibfahn

Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. https Issues or PRs related to the https subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.