test: replaced common.fixturesDir usage with common.fixtures module #15922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
added
the
code-and-learn
BridgeAR
reviewed
Oct 9, 2017
| @@ -34,7 +35,7 @@ let emptyTxt; | |||
| if (common.isWindows) { | |||
| // on Win, common.PIPE will be a named pipe, so we use an existing empty | |||
| // file instead | |||
| emptyTxt = path.join(common.fixturesDir, 'empty.txt'); | |||
| emptyTxt = path.join(fixtures.fixturesDir, 'empty.txt'); | |||
There was a problem hiding this comment.
This should use fixtures.path instead of just replacing where the fixturesDir is coming from.
There was a problem hiding this comment.
@BridgeAR Updated. Thanks!
jasnell
approved these changes
Oct 10, 2017
gireeshpunathil
approved these changes
Oct 12, 2017
lpinca
approved these changes
Oct 13, 2017
|
Failure in CI is unrelated |
jasnell
pushed a commit
that referenced
this pull request
Oct 13, 2017
PR-URL: #15922 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
|
Landed in 584f037 |
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Oct 15, 2017
PR-URL: nodejs/node#15922 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos
pushed a commit
that referenced
this pull request
Oct 18, 2017
PR-URL: #15922 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 16, 2017
PR-URL: #15922 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 21, 2017
PR-URL: #15922 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 28, 2017
PR-URL: #15922 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit replaces common.fixturesDir with the usage of the common.fixtures module
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
None