Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: replace usage of common.fixtures by common.fixturesDir #15917

Closed
wants to merge 1 commit into from
Closed

test: replace usage of common.fixtures by common.fixturesDir #15917

wants to merge 1 commit into from

Conversation

nchaulet
Copy link
Contributor

@nchaulet nchaulet commented Oct 6, 2017

In test/parallel/test-process-redirect-warning.js replace usage of common.fixture by common.fixturesDir

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

tests

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 6, 2017
@mscdex mscdex added the process Issues and PRs related to the process subsystem. label Oct 6, 2017
@Trott Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 6, 2017
BridgeAR
BridgeAR reviewed Oct 9, 2017
View reviewed changes
test/parallel/test-process-redirect-warnings.js Outdated
const fs = require('fs');
const fork = require('child_process').fork;
const path = require('path');
const assert = require('assert');

common.refreshTmpDir();

const warnmod = require.resolve(`${common.fixturesDir}/warnings.js`);
const warnmod = require.resolve(fixtures.path('warnings.js'));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The resolve part should be obsolete.

@nchaulet
test: replace usage of common.fixtures by common.fixturesDir
dbf1d8c 
In test/parallel/test-process-redirect-warning.js replace usage of common.fixture by common.fixturesDir
@joyeecheung
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/10613/

jasnell pushed a commit that referenced this pull request Oct 13, 2017
@nchaulet @jasnell
test: fixtures in test-process-redirect-warnings
8a8cd40 
In test/parallel/test-process-redirect-warning.js replace usage of
common.fixture by common.fixturesDir

PR-URL: #15917
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

jasnell commented Oct 13, 2017

Landed in 8a8cd40

@jasnell jasnell closed this Oct 13, 2017
addaleax pushed a commit to ayojs/ayo that referenced this pull request Oct 15, 2017
@nchaulet @addaleax
test: fixtures in test-process-redirect-warnings
abdfafd 
In test/parallel/test-process-redirect-warning.js replace usage of
common.fixture by common.fixturesDir

PR-URL: nodejs/node#15917
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Oct 18, 2017
@nchaulet @targos
test: fixtures in test-process-redirect-warnings
1cfff97 
In test/parallel/test-process-redirect-warning.js replace usage of
common.fixture by common.fixturesDir

PR-URL: #15917
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
@nchaulet @MylesBorins
test: fixtures in test-process-redirect-warnings
b5aa60e 
In test/parallel/test-process-redirect-warning.js replace usage of
common.fixture by common.fixturesDir

PR-URL: #15917
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Nov 21, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
@nchaulet @MylesBorins
test: fixtures in test-process-redirect-warnings
0a51fe8 
In test/parallel/test-process-redirect-warning.js replace usage of
common.fixture by common.fixturesDir

PR-URL: #15917
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
@nchaulet @MylesBorins
test: fixtures in test-process-redirect-warnings
e705ad2 
In test/parallel/test-process-redirect-warning.js replace usage of
common.fixture by common.fixturesDir

PR-URL: #15917
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR left review comments

@jasnell jasnell jasnell approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. process Issues and PRs related to the process subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@nchaulet @joyeecheung @jasnell @BridgeAR @mscdex @MylesBorins @Trott @nodejs-github-bot