Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: change concatenation to template literal #15916

Closed
wants to merge 1 commit into from
Closed

fs: change concatenation to template literal #15916

wants to merge 1 commit into from

Conversation

nodexpertsdev
Copy link
Contributor

Changed test/parallel/test-fs-copyfile.js

[x] make -j4 test (UNIX), or vcbuild test (Windows) passes

@nodexpertsdev
fs: change concatenation to template literal
a9ca8fd 
Changed test/parallel/test-fs-copyfile.js

[x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 6, 2017
@mscdex mscdex added the fs Issues and PRs related to the fs subsystem / file system. label Oct 6, 2017
@Trott Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 6, 2017
@BridgeAR BridgeAR self-assigned this Oct 9, 2017
BridgeAR pushed a commit that referenced this pull request Oct 9, 2017
@nodexpertsdev @BridgeAR
test: change concatenation to template literal
d4fbffd 
PR-URL: #15916
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@BridgeAR
Copy link
Member

BridgeAR commented Oct 9, 2017

Landed in d4fbffd

Thanks for the PR, and congratulations on becoming a Node.js Contributor 🎉 !

@BridgeAR BridgeAR closed this Oct 9, 2017
MylesBorins pushed a commit that referenced this pull request Oct 11, 2017
@nodexpertsdev @MylesBorins
test: change concatenation to template literal
802f99b 
PR-URL: #15916
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Oct 11, 2017
Merged
addaleax pushed a commit to addaleax/ayo that referenced this pull request Oct 12, 2017
@nodexpertsdev @addaleax
test: change concatenation to template literal
4207ce1 
PR-URL: nodejs/node#15916
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@cjihrig cjihrig cjihrig approved these changes

@watilde watilde watilde approved these changes

@benjamingr benjamingr benjamingr approved these changes

Assignees

@BridgeAR BridgeAR

Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@nodexpertsdev @BridgeAR @benjamingr @watilde @cjihrig @mscdex @MylesBorins @Trott @nodejs-github-bot