Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: replacing common.fixturesDir with common.fixtures module for te… #15907

Closed
wants to merge 2 commits into from
Closed

test: replacing common.fixturesDir with common.fixtures module for te… #15907

wants to merge 2 commits into from

Conversation

oliverluebeck
Copy link
Contributor

…st-tls-honorcipherorder.js

as part of Node.js Interactive 2017, Vancouver BC, Canada

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 6, 2017
@mscdex mscdex added the tls Issues and PRs related to the tls subsystem. label Oct 6, 2017
@Trott Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 6, 2017
Trott
Trott approved these changes Oct 8, 2017
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If you want to make it a bit more concise (and IMO better), switch to using fixtures.readKey(). Docs are at https://github.com/nodejs/node/tree/master/test/common#fixtures-module. But this is also fine as it is, IMO.

@oliverluebeck
Copy link
Contributor Author

good catch! changed it to fixtures.readKey() as suggested.

@Trott
Copy link
Member

Trott commented Oct 9, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/10516/

@Trott Trott self-assigned this Oct 11, 2017
Trott pushed a commit to Trott/io.js that referenced this pull request Oct 11, 2017
@oliverluebeck @Trott
test: replace fixturesDir with common.fixtures
1d7fbab 
In test-tls-honorcipherorder.js, use common.fixtures instead of
common.fixturesDir.

PR-URL: nodejs#15907
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@Trott
Copy link
Member

Trott commented Oct 11, 2017

Landed in 1d7fbab.
Thanks for the contribution! 🎉

@Trott Trott closed this Oct 11, 2017
addaleax pushed a commit to addaleax/ayo that referenced this pull request Oct 12, 2017
@oliverluebeck @addaleax
test: replace fixturesDir with common.fixtures
f511878 
In test-tls-honorcipherorder.js, use common.fixtures instead of
common.fixturesDir.

PR-URL: nodejs/node#15907
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
targos pushed a commit that referenced this pull request Oct 18, 2017
@oliverluebeck @targos
test: replace fixturesDir with common.fixtures
80b276c 
In test-tls-honorcipherorder.js, use common.fixtures instead of
common.fixturesDir.

PR-URL: #15907
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 15, 2017
@oliverluebeck @MylesBorins
test: replace fixturesDir with common.fixtures
43be500 
In test-tls-honorcipherorder.js, use common.fixtures instead of
common.fixturesDir.

PR-URL: #15907
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Nov 21, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
@oliverluebeck @MylesBorins
test: replace fixturesDir with common.fixtures
2fce342 
In test-tls-honorcipherorder.js, use common.fixtures instead of
common.fixturesDir.

PR-URL: #15907
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
@oliverluebeck @MylesBorins
test: replace fixturesDir with common.fixtures
4fd5bf5 
In test-tls-honorcipherorder.js, use common.fixtures instead of
common.fixturesDir.

PR-URL: #15907
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees

@Trott Trott

Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@oliverluebeck @Trott @jasnell @cjihrig @mscdex @MylesBorins @nodejs-github-bot