Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use common.fixtures.fixturesDir #15892

Closed
wants to merge 2 commits into from
Closed

test: use common.fixtures.fixturesDir #15892

wants to merge 2 commits into from

Conversation

r0binary
Copy link

@r0binary r0binary commented Oct 6, 2017

Replace the common.fixturesDir by common.fixtures.fixturesDir
in http2 subsystem test 'server startup'

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 6, 2017
};

// There should not be any throws
assert.doesNotThrow(() => {

const serverTLS = http2.createSecureServer(options, () => {});
const serverTLS = http2.createSecureServer(options, () => { });
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extraneous whitespace, please remove

Replace the common.fixturesDir by common.fixtures.fixturesDir
in http2 subsystem test 'server startup'
@pawelgolda
Copy link
Contributor

Consider using fixtures.readKey instead of fs.readFileSync to get the keys.

@r0binary
Copy link
Author

r0binary commented Oct 6, 2017

@pawelgolda Cool idea, changed it!

@mscdex mscdex added the http2 Issues or PRs related to the http2 subsystem. label Oct 6, 2017
@Trott Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 6, 2017
@BridgeAR BridgeAR self-assigned this Oct 9, 2017
BridgeAR pushed a commit that referenced this pull request Oct 9, 2017
Replace the common.fixturesDir by fixtures.readKey
in http2 subsystem test 'server startup'.

PR-URL: #15892
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@BridgeAR
Copy link
Member

BridgeAR commented Oct 9, 2017

Landed in b5f3054

Thanks for the PR, and congratulations on becoming a Node.js Contributor 🎉 !

@BridgeAR BridgeAR closed this Oct 9, 2017
MylesBorins pushed a commit that referenced this pull request Oct 11, 2017
Replace the common.fixturesDir by fixtures.readKey
in http2 subsystem test 'server startup'.

PR-URL: #15892
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Oct 11, 2017
addaleax pushed a commit to addaleax/ayo that referenced this pull request Oct 12, 2017
Replace the common.fixturesDir by fixtures.readKey
in http2 subsystem test 'server startup'.

PR-URL: nodejs/node#15892
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. http2 Issues or PRs related to the http2 subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants