Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: replace usage of common.fixturesDir by using common.fixtures #15868

Closed
wants to merge 1 commit into from
Closed

test: replace usage of common.fixturesDir by using common.fixtures #15868

wants to merge 1 commit into from

Conversation

nchaulet
Copy link
Contributor

@nchaulet nchaulet commented Oct 6, 2017 •
edited
Loading

Replace usage of common.fixturesDir by using common.fixtures module

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows [commit guidelines]
Affected core subsystem(s)

tests

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 6, 2017
@nchaulet
test: replace usage of common.fixturesDir by using common.fixtures mo…
cd303c5 
…dule

Replace usage of common.fixturesDir by using common.fixtures module in test/parallel/test-pipe-head
@mscdex mscdex added the child_process Issues and PRs related to the child_process subsystem. label Oct 6, 2017
@Trott Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 6, 2017
@refack refack self-assigned this Oct 10, 2017
@lpinca
Copy link
Member

lpinca commented Oct 10, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/10563/

jasnell pushed a commit that referenced this pull request Oct 12, 2017
@nchaulet @jasnell
test: use of fixtures in test-pipe-head
2016ad3 
Replace usage of common.fixturesDir by using common.fixtures
module in test/parallel/test-pipe-head

PR-URL: #15868
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@jasnell
Copy link
Member

jasnell commented Oct 12, 2017

Landed in 2016ad3

@jasnell jasnell closed this Oct 12, 2017
addaleax pushed a commit to ayojs/ayo that referenced this pull request Oct 15, 2017
@nchaulet @addaleax
test: use of fixtures in test-pipe-head
09816df 
Replace usage of common.fixturesDir by using common.fixtures
module in test/parallel/test-pipe-head

PR-URL: nodejs/node#15868
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Oct 18, 2017
@nchaulet @targos
test: use of fixtures in test-pipe-head
1d55d5b 
Replace usage of common.fixturesDir by using common.fixtures
module in test/parallel/test-pipe-head

PR-URL: #15868
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Oct 18, 2017
@nchaulet @targos
test: use of fixtures in test-pipe-head
5a18670 
Replace usage of common.fixturesDir by using common.fixtures
module in test/parallel/test-pipe-head

PR-URL: #15868
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
@nchaulet @MylesBorins
test: use of fixtures in test-pipe-head
b7122f3 
Replace usage of common.fixturesDir by using common.fixtures
module in test/parallel/test-pipe-head

PR-URL: #15868
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Nov 21, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
@nchaulet @MylesBorins
test: use of fixtures in test-pipe-head
0f17c49 
Replace usage of common.fixturesDir by using common.fixtures
module in test/parallel/test-pipe-head

PR-URL: #15868
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
@nchaulet @MylesBorins
test: use of fixtures in test-pipe-head
44a60c3 
Replace usage of common.fixturesDir by using common.fixtures
module in test/parallel/test-pipe-head

PR-URL: #15868
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@refack refack removed their assignment Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tniessen tniessen tniessen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
child_process Issues and PRs related to the child_process subsystem. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@nchaulet @lpinca @jasnell @cjihrig @tniessen @mscdex @refack @MylesBorins @Trott @nodejs-github-bot