Replace string concatenation in tools/doc/type-parser.js with templat… #15827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
rmg
reviewed
Oct 6, 2017
tools/doc/type-parser.js
Outdated
| @@ -87,11 +85,9 @@ module.exports = { | |||
| } | |||
|
|
|||
| if (typeUrl) { | |||
| typeLinks.push('<a href="' + typeUrl + '" class="type"><' + | |||
| typeTextFull + '></a>'); | |||
| typeLinks.push(`<a href="${typeUrl}" class="type"><${typeTextFull}></a>`); | |||
There was a problem hiding this comment.
This makes the linter sad :-(
But we can make it happy by moving the arg to the next line like so:
typeLinks.push(
`<a href="${typeUrl}" class="type"><${typeTextFull}></a>`);There was a problem hiding this comment.
Yes you're right I change it right now
There was a problem hiding this comment.
@rmg - hope you are good with the changes now?
There was a problem hiding this comment.
assuming so, landing now.
Trott
added
the
code-and-learn
lpinca
approved these changes
Oct 9, 2017
doc/guides/writing-tests.md
Outdated
| @@ -148,8 +148,8 @@ const http = require('http'); | |||
| let request = 0; | |||
| let response = 0; | |||
| process.on('exit', function() { | |||
| assert.equal(request, 1, 'http server "request" callback was not called'); | |||
| assert.equal(response, 1, 'http request "response" callback was not called'); | |||
| assert.equal(request, 1, `http server "request" callback was not called`); | |||
There was a problem hiding this comment.
Nit: I find this change unnecessary as there is no concatenation.
|
Ok I just done |
gireeshpunathil
approved these changes
Oct 10, 2017
gireeshpunathil
pushed a commit
that referenced
this pull request
Oct 11, 2017
Replace string concatenation in tools/doc/type-parser.js with template literals PR-URL: #15827 Reviewed-By: Ryan Graham <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
|
Landed in 8c6c060 |
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Oct 12, 2017
Replace string concatenation in tools/doc/type-parser.js with template literals PR-URL: nodejs/node#15827 Reviewed-By: Ryan Graham <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
targos
pushed a commit
that referenced
this pull request
Oct 18, 2017
Replace string concatenation in tools/doc/type-parser.js with template literals PR-URL: #15827 Reviewed-By: Ryan Graham <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e literals
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)