test: fix fixturesDir in test-fs-symlink-dir-junction-relative.js #15822
Conversation
common.fixturesDir -> common.fixtures.fixturesDir
| const assert = require('assert'); | ||
| const path = require('path'); | ||
| const fs = require('fs'); | ||
|
|
||
| const linkPath1 = path.join(common.tmpDir, 'junction1'); | ||
| const linkPath2 = path.join(common.tmpDir, 'junction2'); | ||
| const linkTarget = path.join(common.fixturesDir); | ||
| const linkData = path.join(common.fixturesDir); | ||
| const linkTarget = path.join(fixtures.fixturesDir); |
There was a problem hiding this comment.
I bet this could just be changed to const linkTarget = fixtures.fixuresDir;
There was a problem hiding this comment.
@rmg maybe this could be handled when it lands? See nodejs/code-and-learn#70 (comment). I know this isn't really a nit such as message line lengths, but I agree with @gibfahn that force pushes and amended commits are a bit of a high barrier for code-and-learn first time contributors.
There was a problem hiding this comment.
Trott
added
the
code-and-learn
| const assert = require('assert'); | ||
| const path = require('path'); | ||
| const fs = require('fs'); | ||
|
|
||
| const linkPath1 = path.join(common.tmpDir, 'junction1'); | ||
| const linkPath2 = path.join(common.tmpDir, 'junction2'); | ||
| const linkTarget = path.join(common.fixturesDir); | ||
| const linkData = path.join(common.fixturesDir); | ||
| const linkTarget = path.join(fixtures.fixturesDir); |
There was a problem hiding this comment.
@rmg maybe this could be handled when it lands? See nodejs/code-and-learn#70 (comment). I know this isn't really a nit such as message line lengths, but I agree with @gibfahn that force pushes and amended commits are a bit of a high barrier for code-and-learn first time contributors.
|
CI: https://ci.nodejs.org/job/node-test-pull-request/10560/ |
|
Landed in 734ec0b with #15822 (comment) fixed. Thanks for the contribution! |
PR-URL: #15822 Reviewed-By: Lance Ball <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
PR-URL: nodejs/node#15822 Reviewed-By: Lance Ball <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
PR-URL: #15822 Reviewed-By: Lance Ball <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
PR-URL: #15822 Reviewed-By: Lance Ball <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
PR-URL: #15822 Reviewed-By: Lance Ball <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
PR-URL: #15822 Reviewed-By: Lance Ball <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
N/A