Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: replaces common.fixturesDir usage #15818

Closed
wants to merge 1 commit into from
Closed

test: replaces common.fixturesDir usage #15818

wants to merge 1 commit into from

Conversation

ruyadorno
Copy link
Member

@ruyadorno ruyadorno commented Oct 6, 2017 •
edited
Loading

Description

In test/parallel/test-repl-require.js replaces usage of common.fixturesDir with common/fixtures.

Part of Node.js Interactive 2017 Code & Learn workshop 😊

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 6, 2017
@ruyadorno
test: replaces common.fixturesDir usage
99e4043 
In test/parallel/test-repl-require.js replaces usage of
common.fixturesDir with common/fixtures.

Part of Node.js Interactive 2017 Code & Learn
@ruyadorno ruyadorno changed the title Replaces common.fixturesDir with common.fixtures test: replaces common.fixturesDir usage Oct 6, 2017
@mscdex mscdex added the repl Issues and PRs related to the REPL subsystem. label Oct 6, 2017
@Trott Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 6, 2017
@lpinca
Copy link
Member

lpinca commented Oct 9, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/10525/

gireeshpunathil pushed a commit that referenced this pull request Oct 11, 2017
@ruyadorno @gireeshpunathil
test: replaces common.fixturesDir usage
2ea902b 
In test/parallel/test-repl-require.js replaces usage of
common.fixturesDir with common/fixtures.

Part of Node.js Interactive 2017 Code & Learn

PR-URL: #15818
Reviewed-By: Ryan Graham <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
@gireeshpunathil
Copy link
Member

Landed in 2ea902b

@Trott
Copy link
Member

Trott commented Oct 11, 2017

Thanks for the contribution! 🎉

@ruyadorno ruyadorno deleted the replaces-fixtures-dir-usage branch October 11, 2017 13:47
addaleax pushed a commit to addaleax/ayo that referenced this pull request Oct 12, 2017
@ruyadorno @addaleax
test: replaces common.fixturesDir usage
4f7eba5 
In test/parallel/test-repl-require.js replaces usage of
common.fixturesDir with common/fixtures.

Part of Node.js Interactive 2017 Code & Learn

PR-URL: nodejs/node#15818
Reviewed-By: Ryan Graham <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
targos pushed a commit that referenced this pull request Oct 18, 2017
@ruyadorno @targos
test: replaces common.fixturesDir usage
25335ec 
In test/parallel/test-repl-require.js replaces usage of
common.fixturesDir with common/fixtures.

Part of Node.js Interactive 2017 Code & Learn

PR-URL: #15818
Reviewed-By: Ryan Graham <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 15, 2017
@ruyadorno @MylesBorins
test: replaces common.fixturesDir usage
e2a23d4 
In test/parallel/test-repl-require.js replaces usage of
common.fixturesDir with common/fixtures.

Part of Node.js Interactive 2017 Code & Learn

PR-URL: #15818
Reviewed-By: Ryan Graham <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Nov 21, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
@ruyadorno @MylesBorins
test: replaces common.fixturesDir usage
0e35ca7 
In test/parallel/test-repl-require.js replaces usage of
common.fixturesDir with common/fixtures.

Part of Node.js Interactive 2017 Code & Learn

PR-URL: #15818
Reviewed-By: Ryan Graham <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
@ruyadorno @MylesBorins
test: replaces common.fixturesDir usage
4cf84ea 
In test/parallel/test-repl-require.js replaces usage of
common.fixturesDir with common/fixtures.

Part of Node.js Interactive 2017 Code & Learn

PR-URL: #15818
Reviewed-By: Ryan Graham <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@richardlau richardlau richardlau approved these changes

@lpinca lpinca lpinca approved these changes

@benjamingr benjamingr benjamingr approved these changes

@jasnell jasnell jasnell approved these changes

@rmg rmg rmg approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. repl Issues and PRs related to the REPL subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.