src: remove unused node_dtrace.h from node_win32 #15768
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the inclusion of node_dtrace.h from node_win32_etw_provider.cc. I was not expecting to find it in a windows source file and could not find any usage of it.
nodejs-github-bot
added
c++
bnoordhuis
approved these changes
Oct 4, 2017
JungMinu
approved these changes
Oct 4, 2017
lpinca
approved these changes
Oct 5, 2017
cjihrig
approved these changes
Oct 5, 2017
danbev
added a commit
to danbev/node
that referenced
this pull request
Oct 6, 2017
This commit removes the inclusion of node_dtrace.h from node_win32_etw_provider.cc. I was not expecting to find it in a windows source file and could not find any usage of it. PR-URL: nodejs#15768 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
|
Landed in 4f339b5 |
sashimii
pushed a commit
to sashimii/node
that referenced
this pull request
Oct 7, 2017
This commit removes the inclusion of node_dtrace.h from node_win32_etw_provider.cc. I was not expecting to find it in a windows source file and could not find any usage of it. PR-URL: nodejs#15768 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 7, 2017
This commit removes the inclusion of node_dtrace.h from node_win32_etw_provider.cc. I was not expecting to find it in a windows source file and could not find any usage of it. PR-URL: #15768 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Oct 11, 2017
This commit removes the inclusion of node_dtrace.h from node_win32_etw_provider.cc. I was not expecting to find it in a windows source file and could not find any usage of it. PR-URL: #15768 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Oct 12, 2017
This commit removes the inclusion of node_dtrace.h from node_win32_etw_provider.cc. I was not expecting to find it in a windows source file and could not find any usage of it. PR-URL: nodejs/node#15768 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
|
Should this be backported to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the inclusion of node_dtrace.h from
node_win32_etw_provider.cc. I was not expecting to find it in a windows
source file and could not find any usage of it.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
src