Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: refactor test-internal-errors #15721

Closed
wants to merge 1 commit into from
Closed

test: refactor test-internal-errors #15721

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Oct 2, 2017

Use block-scoping rather than err1, err2, etc.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Use block-scoping rather than `err1`, `err2`, etc.
@Trott Trott added the test Issues and PRs related to the tests. label Oct 2, 2017
@mscdex mscdex added the errors Issues and PRs related to JavaScript errors originated in Node.js core. label Oct 2, 2017
@Trott
Copy link
Member Author

Trott commented Oct 4, 2017

Trott added a commit to Trott/io.js that referenced this pull request Oct 5, 2017
Use block-scoping rather than `err1`, `err2`, etc.

PR-URL: nodejs#15721
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@Trott
Copy link
Member Author

Trott commented Oct 5, 2017

Landed in 9569ca8

@Trott Trott closed this Oct 5, 2017
MylesBorins pushed a commit that referenced this pull request Oct 7, 2017
Use block-scoping rather than `err1`, `err2`, etc.

PR-URL: #15721
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Oct 7, 2017
MylesBorins pushed a commit that referenced this pull request Oct 11, 2017
Use block-scoping rather than `err1`, `err2`, etc.

PR-URL: #15721
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
addaleax pushed a commit to addaleax/ayo that referenced this pull request Oct 12, 2017
Use block-scoping rather than `err1`, `err2`, etc.

PR-URL: nodejs/node#15721
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@Trott Trott deleted the block branch January 13, 2022 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
errors Issues and PRs related to JavaScript errors originated in Node.js core. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants