Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: ctc -> tsc in onboarding extras #15621

Closed
wants to merge 1 commit into from
Closed

doc: ctc -> tsc in onboarding extras #15621

wants to merge 1 commit into from

Conversation

bengl
Copy link
Member

@bengl bengl commented Sep 26, 2017

(Missed this one when doing #15590, oops! I think I've got them all now.)

Checklist
Affected core subsystem(s)

doc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 26, 2017
jasnell
jasnell approved these changes Sep 26, 2017
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't need to wait the 48 hours to land

@Trott
Copy link
Member

Trott commented Sep 26, 2017

+1 to @jasnell's comment about this not needing to wait. (Would have used an emoji reaction but the interface doesn't allow it for change-approval messages like that.)

@lpinca
Copy link
Member

lpinca commented Sep 26, 2017

Landed in f9e5709.

lpinca pushed a commit that referenced this pull request Sep 26, 2017
@bengl @lpinca
doc: ctc -> tsc in onboarding extras
f9e5709 
PR-URL: #15621
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@lpinca lpinca closed this Sep 26, 2017
@gibfahn
Copy link
Member

gibfahn commented Sep 26, 2017

+1 to @jasnell's comment about this not needing to wait. (Would have used an emoji reaction but the interface doesn't allow it for change-approval messages like that.)

FWIW I always add that as a separate comment so people can 👍 it.

jasnell pushed a commit that referenced this pull request Sep 26, 2017
@bengl @jasnell
doc: ctc -> tsc in onboarding extras
f6b4844 
PR-URL: #15621
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins pushed a commit that referenced this pull request Sep 29, 2017
@bengl @MylesBorins
doc: ctc -> tsc in onboarding extras
fa07b27 
PR-URL: #15621
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
addaleax pushed a commit to addaleax/ayo that referenced this pull request Sep 30, 2017
@bengl @addaleax
doc: ctc -> tsc in onboarding extras
3029596 
PR-URL: nodejs/node#15621
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Oct 3, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 14, 2017
@bengl @MylesBorins
doc: ctc -> tsc in onboarding extras
4515658 
PR-URL: #15621
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Nov 21, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
@bengl @MylesBorins
doc: ctc -> tsc in onboarding extras
d62b78c 
PR-URL: #15621
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
@bengl @MylesBorins
doc: ctc -> tsc in onboarding extras
23e9bba 
PR-URL: #15621
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiroppy hiroppy hiroppy approved these changes

@XadillaX XadillaX XadillaX approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@bengl @Trott @lpinca @gibfahn @jasnell @XadillaX @hiroppy @MylesBorins @nodejs-github-bot