Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4.8.5 proposal #15507

Closed
wants to merge 32 commits into from
Closed

v4.8.5 proposal #15507

wants to merge 32 commits into from

Commits on Jul 11, 2017

  1. deps/v8: add missing #include "unicode/normlzr.h"

    * The following function from <unicode/normlzr.h> is used:
         normalize()
    
    * Until ICU 59, <unicode/normlzr.h> is indirectly included, but this changed with the 59 release. Adding this header has been the right thing to do for many years, so it is backwards compatible and fix compilation with recent ICU.
    
    Refs: #13022
    PR-URL: #13040
    Reviewed-By: Ben Noordhuis <[email protected]>
    Reviewed-By: Myles Borins <[email protected]>
    Reviewed-By: Gibson Fahnestock <[email protected]>
    ArchangeGabriel authored and MylesBorins committed Jul 11, 2017
    1 Configuration menu
    Copy the full SHA
    0b1df7e View commit details
    Browse the repository at this point in the history
  2. deps: cherry-pick 4ae5993 from upstream OpenSSL

    This fixes wrong hash results on Windows with some CPUs that support
    Intel SHA Extension and resolves the issue of TLS connection errors.
    
    After upgrading forthcoming openssl-1.0.2l, this is no nolonger needed.
    
      Original commit message:
    
        perlasm/x86_64-xlate.pl: work around problem with hex constants in masm.
    
        Perl, multiple versions, for some reason occasionally takes issue with
        letter b[?] in ox([0-9a-f]+) regex. As result some constants, such as
        0xb1 came out wrong when generating code for MASM. Fixes GH#3241.
    
        Reviewed-by: Rich Salz <[email protected]>
        (Merged from openssl/openssl#3385)
    
        (cherry picked from commit c47aea8af1e28e46e1ad5e2e7468b49fec3f4f29)
    
    Refs: openssl/openssl#3241
    Refs: openssl/openssl#3385
    Fixes: #12691
    PR-URL: #12913
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Sam Roberts <[email protected]>
    Reviewed-By: Anna Henningsen <[email protected]>
    shigeki authored and MylesBorins committed Jul 11, 2017
    Configuration menu
    Copy the full SHA
    f4c5874 View commit details
    Browse the repository at this point in the history
  3. deps: update openssl asm and asm_obsolete files

    Regenerate asm files according to the fix of
    openssl/crypto/perlasm/x86_64-xlate.pl.
    
    Fixes: #12691
    PR-URL: #12913
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Sam Roberts <[email protected]>
    Reviewed-By: Anna Henningsen <[email protected]>
    shigeki authored and MylesBorins committed Jul 11, 2017
    Configuration menu
    Copy the full SHA
    64f5b73 View commit details
    Browse the repository at this point in the history
  4. v8: fix stack overflow in recursive method

    HGlobalValueNumberingPhase::CollectSideEffectsOnPathsToDominatedBlock()
    used to self-recurse before this commit, causing stack overflows on
    systems with small stack sizes.  Make it non-recursive by storing
    intermediate results in a heap-allocated list.
    
    Fixes: #11991
    Backport-PR-URL: #13080
    PR-URL: #12460
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Yang Guo <[email protected]>
    bnoordhuis authored and MylesBorins committed Jul 11, 2017
    Configuration menu
    Copy the full SHA
    0bcd62b View commit details
    Browse the repository at this point in the history
  5. crypto: clear err stack after ECDH::BufferToPoint

    Functions that call `ECDH::BufferToPoint` were not clearing the
    error stack on failure, so an invalid key could leave leftover
    error state and cause subsequent (unrelated) signing operations
    to fail.
    
    PR-URL: #13275
    Backport-PR-URL: #13399
    Reviewed-By: Fedor Indutny <[email protected]>
    Reviewed-By: Ben Noordhuis <[email protected]>
    Reviewed-By: Sam Roberts <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    rfk authored and MylesBorins committed Jul 11, 2017
    Configuration menu
    Copy the full SHA
    61f0464 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2017

  1. build: avoid /docs/api and /docs/doc/api upload

    Fixes: #12833
    PR-URL: #12957
    Reviewed-By: João Reis <[email protected]>
    Reviewed-By: Gibson Fahnestock <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    rvagg authored and MylesBorins committed Jul 17, 2017
    Configuration menu
    Copy the full SHA
    40fb0da View commit details
    Browse the repository at this point in the history
  2. tools: be explicit about including key-id

    gpg 2.1 no longer includes the key-id by default which breaks
    the release script. This makes sure we are explicit about it.
    
    PR-URL: #13309
    Reviewed-By: Gibson Fahnestock <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    MylesBorins committed Jul 17, 2017
    Configuration menu
    Copy the full SHA
    8c9f1b3 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2017

  1. doc: change child to subprocess

    Backport-PR-URL: #14635
    PR-URL: #14578
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Refael Ackermann <[email protected]>
    Trott authored and MylesBorins committed Aug 11, 2017
    Configuration menu
    Copy the full SHA
    fd27dc7 View commit details
    Browse the repository at this point in the history
  2. doc: add entry for subprocess.killed property

    Backport-PR-URL: #14635
    PR-URL: #14578
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Refael Ackermann <[email protected]>
    Trott authored and MylesBorins committed Aug 11, 2017
    Configuration menu
    Copy the full SHA
    244983a View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2017

  1. build,tools: do not force codesign prefix

    Allow passing the prefix in via the PKGDIR env var. This will allow us
    to use this same script to codesign the binary tarball.
    
    PR-URL: #14179
    Reviewed-By: Refael Ackermann <[email protected]>
    Reviewed-By: Ben Noordhuis <[email protected]>
    Reviewed-By: Myles Borins <[email protected]>
    Reviewed-By: Gibson Fahnestock <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    evanlucas authored and MylesBorins committed Aug 16, 2017
    Configuration menu
    Copy the full SHA
    70f2299 View commit details
    Browse the repository at this point in the history
  2. build: codesign tarball binary on macOS

    Previously, we were signing the binary that was released in the .pkg,
    but not the binary released in the tarball.
    
    PR-URL: #14179
    Fixes: #11936
    Reviewed-By: Refael Ackermann <[email protected]>
    Reviewed-By: Ben Noordhuis <[email protected]>
    Reviewed-By: Myles Borins <[email protected]>
    Reviewed-By: Gibson Fahnestock <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    evanlucas authored and MylesBorins committed Aug 16, 2017
    Configuration menu
    Copy the full SHA
    dc05da7 View commit details
    Browse the repository at this point in the history
  3. deps: cherry-pick 18ea996 from c-ares upstream

    Original commit message:
    
        ares_parse_naptr_reply: make buffer length check more accurate
    
        9478908a490a6bf009ba58d81de8c1d06d50a117 introduced a length check
        for records parsed by `ares_parse_naptr_reply()`. However, that
        function is designed to parse replies which also contain non-NAPTR
        records; for A records, the `rr_len > 7` check will fail as there
        are only 4 bytes of payload.
        In particular, parsing ANY replies for NAPTR records was broken
        by that patch.
    
        Fix that by moving the check into the case in which it is already
        known that the record is a NAPTR record.
    
    Ref: c-ares/c-ares@18ea996
    PR-URL: #13883
    Reviewed-By: James M Snell <[email protected]>
    addaleax authored and MylesBorins committed Aug 16, 2017
    Configuration menu
    Copy the full SHA
    dabc7c3 View commit details
    Browse the repository at this point in the history
  4. tools: update certdata.txt

    This is the certdata.txt[0] that ships in NSS 3.28.1, released on
    2017-01-04.
    
    [0] https://hg.mozilla.org/projects/nss/raw-file/NSS_3_28_1_RTM/lib/ckfw/builtins/certdata.txt
    
    PR-URL: #12402
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Shigeki Ohtsu <[email protected]>
    bnoordhuis authored and MylesBorins committed Aug 16, 2017
    Configuration menu
    Copy the full SHA
    6fa2d7e View commit details
    Browse the repository at this point in the history
  5. crypto: update root certificates

    Update the list of root certificates in src/node_root_certs.h with
    tools/mk-ca-bundle.pl.
    
    Certificates added:
    - AC RAIZ FNMT-RCM
    - Amazon Root CA 1
    - Amazon Root CA 2
    - Amazon Root CA 3
    - Amazon Root CA 4
    - Certplus Root CA G1
    - Certplus Root CA G2
    - Hellenic Academic and Research Institutions ECC RootCA 2015
    - Hellenic Academic and Research Institutions RootCA 2015
    - ISRG Root X1
    - LuxTrust Global Root 2
    - OpenTrust Root CA G1
    - OpenTrust Root CA G2
    - OpenTrust Root CA G3
    
    Certificates removed:
    - Buypass Class 2 CA 1
    - EBG Elektronik Sertifika Hizmet Sağlayıcısı
    - IGC/A
    - Juur-SK
    - RSA Security 2048 v3
    - Root CA Generalitat Valenciana
    
    PR-URL: #12402
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Shigeki Ohtsu <[email protected]>
    bnoordhuis authored and MylesBorins committed Aug 16, 2017
    Configuration menu
    Copy the full SHA
    491f8c7 View commit details
    Browse the repository at this point in the history
  6. tools: update certdata.txt

    This is the certdata.txt[0] that ships in NSS 3.30.2, released on
    2017-04-20.
    
    [0] https://hg.mozilla.org/projects/nss/raw-file/NSS_3_30_2_RTM/lib/ckfw/builtins/certdata.txt
    
    PR-URL: #13279
    Reviewed-By: Sam Roberts <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    bnoordhuis authored and MylesBorins committed Aug 16, 2017
    Configuration menu
    Copy the full SHA
    fdcfc4c View commit details
    Browse the repository at this point in the history
  7. crypto: update root certificates

    Update the list of root certificates in src/node_root_certs.h with
    tools/mk-ca-bundle.pl.
    
    Certificates added:
    - TUBITAK Kamu SM SSL Kok Sertifikasi - Surum 1
    
    Certificates removed:
    - ApplicationCA - Japanese Government
    - Microsec e-Szigno Root CA
    - TÜRKTRUST Elektronik Sertifika Hizmet Sağlayıcısı H6
    - WellsSecure Public Root Certificate Authority
    
    PR-URL: #13279
    Reviewed-By: Sam Roberts <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    bnoordhuis authored and MylesBorins committed Aug 16, 2017
    Configuration menu
    Copy the full SHA
    fc6d118 View commit details
    Browse the repository at this point in the history
  8. Revert "deps: backport e093a04, 09db540 from upstream V8"

    This reverts commit 2d07fd7, with the
    exception of the `V8_PATCH_LEVEL` which will continue to increase.
    
    This commit was intended to be a backport of v8's e093a04 and 09db540,
    but it failed to consider the reversion of e093a04 in 5f5a328.
    
    PR-URL: #14829
    Reviewed-By: Ben Noordhuis <[email protected]>
    abernix authored and MylesBorins committed Aug 16, 2017
    Configuration menu
    Copy the full SHA
    df23963 View commit details
    Browse the repository at this point in the history
  9. deps: cherry-pick 09db540,686558d from V8 upstream

    Original commit messages:
    v8/v8@09db540
      Reland of Rehash and clear deleted entries in weak collections during GC
    
      BUG=v8:4909
      [email protected],[email protected]
      LOG=n
    
      Review URL: https://codereview.chromium.org/1890123002
    
      Cr-Commit-Position: refs/heads/master@{#35538}
    
    v8/v8@686558d
      Fix comment about when we rehash ObjectHashTables before growing them
    
      [email protected]
      BUG=
    
      Review-Url: https://codereview.chromium.org/1918403003
      Cr-Commit-Position: refs/heads/master@{#35853}
    
    Refs: https://crbug.com/v8/4909
    Refs: #6180
    Refs: #7689
    Refs: #6398
    Fixes: #14228
    
    PR-URL: #14829
    Reviewed-By: Ben Noordhuis <[email protected]>
    abernix authored and MylesBorins committed Aug 16, 2017
    Configuration menu
    Copy the full SHA
    5d7f68a View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2017

  1. deps: add example of comparing OpenSSL changes

    When upgrading OpenSSL, Step 6 in upgrading guide explains the steps
    that need to be taken if asm files need updating. This might not
    always be the case and something that needs to be checked from
    release to release.
    
    This commit adds an example of using github to manually compare two tags
    to see if any changes were made to asm files.
    
    Backport-PR-URL: #13696
    PR-URL: #13234
    Reviewed-By: Ben Noordhuis <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Richard Lau <[email protected]>
    danbev authored and MylesBorins committed Sep 19, 2017
    Configuration menu
    Copy the full SHA
    0286833 View commit details
    Browse the repository at this point in the history
  2. deps: upgrade openssl sources to 1.0.2l

    This replaces all sources of openssl-1.0.2l.tar.gz into
    deps/openssl/openssl
    
    Fixes: #13161
    Backport-PR-URL: #13696
    PR-URL: #13233
    Reviewed-By: Shigeki Ohtsu <[email protected]>
    Reviewed-By: Sam Roberts <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    danbev authored and MylesBorins committed Sep 19, 2017
    Configuration menu
    Copy the full SHA
    a5a8065 View commit details
    Browse the repository at this point in the history
  3. deps: copy all openssl header files to include dir

    All symlink files in deps/openssl/openssl/include/openssl/ are removed
    and replaced with real header files to avoid issues on Windows. Two
    files of opensslconf.h in crypto and include dir are replaced to refer
    config/opensslconf.h.
    
    Fixes: #13161
    Backport-PR-URL: #13696
    PR-URL: #13233
    Reviewed-By: Shigeki Ohtsu <[email protected]>
    Reviewed-By: Sam Roberts <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    danbev authored and MylesBorins committed Sep 19, 2017
    Configuration menu
    Copy the full SHA
    283dd73 View commit details
    Browse the repository at this point in the history
  4. deps: fix openssl assembly error on ia32 win32

    `x86masm.pl` was mistakenly using .486 instruction set, why `cpuid` (and
    perhaps others) are requiring .686 .
    
    Fixes: #589
    Backport-PR-URL: #13696
    PR-URL: #1389
    Reviewed-By: Fedor Indutny <[email protected]>
    Reviewed-By: Ben Noordhuis <[email protected]>
    Reviewed-By: Shigeki Ohtsu <[email protected]>
    indutny authored and MylesBorins committed Sep 19, 2017
    Configuration menu
    Copy the full SHA
    0bacd2d View commit details
    Browse the repository at this point in the history
  5. deps: fix asm build error of openssl in x86_win32

    See
    https://mta.openssl.org/pipermail/openssl-dev/2015-February/000651.html
    
    iojs needs to stop using masm and move to nasm or yasm on Win32.
    
    Fixes: #589
    Backport-PR-URL: #13696
    PR-URL: #1389
    Reviewed-By: Fedor Indutny <[email protected]>
    Reviewed-By: Ben Noordhuis <[email protected]>
    Shigeki Ohtsu authored and MylesBorins committed Sep 19, 2017
    Configuration menu
    Copy the full SHA
    a4e947f View commit details
    Browse the repository at this point in the history
  6. openssl: fix keypress requirement in apps on win32

    Reapply b910613 .
    
    Fixes: #589
    Backport-PR-URL: #13696
    PR-URL: #1389
    Reviewed-By: Fedor Indutny <[email protected]>
    Reviewed-By: Ben Noordhuis <[email protected]>
    Shigeki Ohtsu authored and MylesBorins committed Sep 19, 2017
    Configuration menu
    Copy the full SHA
    d93ef98 View commit details
    Browse the repository at this point in the history
  7. deps: add -no_rand_screen to openssl s_client

    In openssl s_client on Windows, RAND_screen() is invoked to initialize
    random state but it takes several seconds in each connection.
    This added -no_rand_screen to openssl s_client on Windows to skip
    RAND_screen() and gets a better performance in the unit test of
    test-tls-server-verify.
    Do not enable this except to use in the unit test.
    
    Fixes: #1461
    Backport-PR-URL: #13696
    PR-URL: #1836
    Reviewed-By: Ben Noordhuis <[email protected]>
    Shigeki Ohtsu authored and MylesBorins committed Sep 19, 2017
    Configuration menu
    Copy the full SHA
    c98f78d View commit details
    Browse the repository at this point in the history
  8. deps: update openssl config files

    Regenerate config files for supported platforms with Makefile.
    
    Fixes: #13161
    Backport-PR-URL: #13696
    PR-URL: #13233
    Reviewed-By: Shigeki Ohtsu <[email protected]>
    Reviewed-By: Sam Roberts <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    danbev authored and MylesBorins committed Sep 19, 2017
    Configuration menu
    Copy the full SHA
    df2ee21 View commit details
    Browse the repository at this point in the history
  9. deps: update openssl asm and asm_obsolete files

    Regenerate asm files with Makefile and CC=gcc and ASM=nasm where gcc
    version was 5.4.0 and nasm version was 2.11.08.
    
    Also asm files in asm_obsolete dir to support old compiler and
    assembler are regenerated without CC and ASM envs.
    
    Fixes: #13161
    Backport-PR-URL: #13696
    PR-URL: #13233
    Reviewed-By: Shigeki Ohtsu <[email protected]>
    Reviewed-By: Sam Roberts <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    danbev authored and MylesBorins committed Sep 19, 2017
    Configuration menu
    Copy the full SHA
    84a838e View commit details
    Browse the repository at this point in the history
  10. doc: add missing make command to UPGRADING.md

    Added the missing make command in steps 6.3 when building
    asm_obsolete.
    
    Also updated the commit message to include the version nasm in
    addition to the gcc version.
    
    Fixes: #13161
    Backport-PR-URL: #13696
    PR-URL: #13233
    Reviewed-By: Shigeki Ohtsu <[email protected]>
    Reviewed-By: Sam Roberts <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    danbev authored and MylesBorins committed Sep 19, 2017
    Configuration menu
    Copy the full SHA
    273e02d View commit details
    Browse the repository at this point in the history
  11. zlib: fix node crashing on invalid options

    This is a partial backport of semver-patch bits of
    9e4660b.
    
    This commit fixes the Node process crashing when constructors of classes
    of the zlib module are given invalid options.
    
    * Throw an Error when the zlib library rejects the value of windowBits,
      instead of crashing with an assertion.
    
    * Treat windowBits and memLevel options consistently with other ones and
      don't crash when non-numeric values are given.
    
    Backport-PR-URL: #14860
    PR-URL: #13098
    Fixes: #13082
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Sakthipriyan Vairamani <[email protected]>
    aqrln authored and MylesBorins committed Sep 19, 2017
    Configuration menu
    Copy the full SHA
    2a8ef7a View commit details
    Browse the repository at this point in the history
  12. zlib: fix crash when initializing failed

    Unset `mode_` when initializing the zlib stream failed, so that
    we don’t try to call the zlib end functions (`deflateEnd()` etc.)
    when cleaning up in `ZCtx::Close()`.
    
    Fixes: #14178
    Ref: #13098
    Backport-PR-URL: #14860
    PR-URL: #14666
    Reviewed-By: Refael Ackermann <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Alexey Orlenko <[email protected]>
    addaleax authored and MylesBorins committed Sep 19, 2017
    Configuration menu
    Copy the full SHA
    5422eb8 View commit details
    Browse the repository at this point in the history
  13. docs: Fix broken links in crypto.md

    PR-URL: #15182
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Luigi Pinca <[email protected]>
    Reviewed-By: Roman Reiss <[email protected]>
    Reviewed-By: Daniel Bevenius <[email protected]>
    Zuzana Svetlikova authored and MylesBorins committed Sep 19, 2017
    Configuration menu
    Copy the full SHA
    fc6145f View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2017

  1. 2017-10-03, Version 4.8.5 'Argon' (Maintenance)

    Notable Changes:
    
    Coming Soon
    
    PR-URL: #15507
    MylesBorins committed Sep 20, 2017
    Configuration menu
    Copy the full SHA
    7648b22 View commit details
    Browse the repository at this point in the history