-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: move test-benchmark-buffer to sequential #15373
Conversation
`test-benchmark-buffer` has been observed to timeout on CI on SmartOS. Move the test to `sequential` so it is not competing with other tests for resources. Fixes: nodejs#15372
Stress test (started by @mscdex) to see if it's not a problem with the test itself: https://ci.nodejs.org/job/node-stress-single-test/1409/ If that stress test comes back green, that would suggest that moving the test to If that stress test comes back red, that would suggest that moving the test to |
Cross-ref: https://ci.nodejs.org/job/node-stress-single-test/1409/ was stopped after 19h (OK: 1934 NOT OK: 0). I'd say it's stable on it's own. |
This needs a rebase. |
..nvm .. I rebased on landing... |
`test-benchmark-buffer` has been observed to timeout on CI on SmartOS. Move the test to `sequential` so it is not competing with other tests for resources. PR-URL: #15373 Fixes: #15372 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: James M Snell <[email protected]>
Landed in 082c434 |
`test-benchmark-buffer` has been observed to timeout on CI on SmartOS. Move the test to `sequential` so it is not competing with other tests for resources. PR-URL: nodejs/node#15373 Fixes: nodejs/node#15372 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: James M Snell <[email protected]>
`test-benchmark-buffer` has been observed to timeout on CI on SmartOS. Move the test to `sequential` so it is not competing with other tests for resources. PR-URL: #15373 Fixes: #15372 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: James M Snell <[email protected]>
`test-benchmark-buffer` has been observed to timeout on CI on SmartOS. Move the test to `sequential` so it is not competing with other tests for resources. PR-URL: nodejs/node#15373 Fixes: nodejs/node#15372 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: James M Snell <[email protected]>
test-benchmark-buffer
has been observed to timeout on CI on SmartOS.Move the test to
sequential
so it is not competing with other testsfor resources.
Fixes: #15372
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
test benchmark buffer