Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: remove unused perf_hooks uv handles #15368

Closed
wants to merge 1 commit into from
Closed

src: remove unused perf_hooks uv handles #15368

wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Sep 12, 2017

A couple of unused uv handles were accidentally left in env.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src

@jasnell
src: remove unused perf_hooks uv handles
52e03a0 
A couple of unused uv handles were accidentally left
in env.
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Sep 12, 2017
@mscdex
Copy link
Contributor

mscdex commented Sep 12, 2017

LGTM if CI is ok: https://ci.nodejs.org/job/node-test-pull-request/10046/

@addaleax
Copy link
Member

CI looks good, I don’t think this needs to wait 48 hours

jasnell added a commit that referenced this pull request Sep 13, 2017
@jasnell
src: remove unused perf_hooks uv handles
dcc41fd 
A couple of unused uv handles were accidentally left
in env.

PR-URL: #15368
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Brian White <[email protected]>
@jasnell
Copy link
Member Author

jasnell commented Sep 13, 2017

Landed in dcc41fd

@jasnell jasnell closed this Sep 13, 2017
addaleax pushed a commit to addaleax/ayo that referenced this pull request Sep 17, 2017
@jasnell @addaleax
src: remove unused perf_hooks uv handles
4c11362 
A couple of unused uv handles were accidentally left
in env.

PR-URL: nodejs/node#15368
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Brian White <[email protected]>
jasnell added a commit that referenced this pull request Sep 20, 2017
@jasnell
src: remove unused perf_hooks uv handles
29e38ab 
A couple of unused uv handles were accidentally left
in env.

PR-URL: #15368
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Brian White <[email protected]>
@jasnell jasnell mentioned this pull request Sep 20, 2017
Merged
Qard pushed a commit to Qard/ayo that referenced this pull request Sep 21, 2017
@jasnell
src: remove unused perf_hooks uv handles
9987372 
A couple of unused uv handles were accidentally left
in env.

PR-URL: nodejs/node#15368
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Brian White <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jasnell @mscdex @addaleax @cjihrig @MylesBorins @nodejs-github-bot