child_process: remove shell option before fork #15299

ghost · 2017-09-09T20:50:35Z

Checklist

[x ] make -j4 test (UNIX), or vcbuild test (Windows) passes
[x ] tests and/or benchmarks are included
[x ] documentation is changed or added

Affected core subsystem(s)

child_process

cjihrig · 2017-09-09T21:00:57Z

This should have a test. #13983 can probably help with that. We should also document the behavior. It might also be better if we can do this without the Windows check.

ghost · 2017-09-09T21:09:41Z

I missed the entire test generation section of the contribution doc. First time at this.

*Edit: I checked in a test. Thanks for the gentle reminder/nudge. In the spirit of this being my first attempt at a contribution it is about as complex as the actual code change but hopefully sufficient. On to documentation.

Test for #15299

ghost · 2017-09-09T22:55:30Z

RE: Not doing the platform check - do you want me to just explicitly set it false and document that shell isn't supported for fork?

cjihrig · 2017-09-10T03:49:03Z

@agresnel I think that based on #13983 (comment), that should be fine. Thanks for taking care of this.

cjihrig

A couple comments. I think you might want to consider something like this for the test:

'use strict';
// Refs: https://github.com/nodejs/node/issues/13983
// This test verifies that the shell option is not supported by fork().
require('../common');
const assert = require('assert');
const cp = require('child_process');

if (process.argv[2] === undefined) {
  cp.fork(__filename, ['$foo'], {
    shell: true,
    env: { foo: 'bar' }
  });
} else {
  assert.strictEqual(process.argv[2], '$foo');
}

I only tried this test on macOS. You probably need to conditionally use %foo% instead of $foo on Windows.

cjihrig · 2017-09-10T17:57:54Z

doc/api/child_process.md

@@ -335,7 +335,7 @@ The `child_process.fork()` method is a special case of
 Like [`child_process.spawn()`][], a [`ChildProcess`][] object is returned. The returned
 [`ChildProcess`][] will have an additional communication channel built-in that
 allows messages to be passed back and forth between the parent and child. See
-[`subprocess.send()`][] for details.
+[`subprocess.send()`][] for details.  


Extra whitespace change here.

cjihrig · 2017-09-10T17:58:55Z

test/parallel/test-child-process-fork-noshell.js

@@ -0,0 +1,29 @@
+// Copyright Joyent, Inc. and other Node contributors.


New files don't need this copyright header. You can remove it.

cjihrig · 2017-09-10T17:59:51Z

test/parallel/test-child-process-fork-noshell.js

+const child_process = require('child_process');
+const fixtures = require('../common/fixtures');
+
+//As per: https://github.com/nodejs/node/issues/13983 should produce no error output


Space after //.

Lines should be wrapped at 80 characters too. make lint should have caught this.

Fishrock123 · 2017-09-11T19:16:54Z

The PR owner's account appears to have been deleted. @cjihrig if you are interested in this you may want to take their commit and make a new PR from it.

cjihrig · 2017-09-11T19:19:04Z

@Fishrock123 thanks for the heads up. Will do.

cjihrig · 2017-09-12T01:10:10Z

Moved to #15352

This commit ensures that spawn()'s shell option is unconditionally set to false when fork() is called. Refs: nodejs#15299 Fixes: nodejs#13983 PR-URL: nodejs#15352 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>

This commit verifies that the child_process fork() method does not honor the shell option. Refs: nodejs#15299 PR-URL: nodejs#15352 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>

This commit ensures that spawn()'s shell option is unconditionally set to false when fork() is called. Refs: nodejs/node#15299 Fixes: nodejs/node#13983 PR-URL: nodejs/node#15352 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>

This commit verifies that the child_process fork() method does not honor the shell option. Refs: nodejs/node#15299 PR-URL: nodejs/node#15352 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>

This commit verifies that the child_process fork() method does not honor the shell option. Refs: #15299 PR-URL: #15352 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>

This commit ensures that spawn()'s shell option is unconditionally set to false when fork() is called. Refs: #15299 Fixes: #13983 PR-URL: #15352 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>

This commit ensures that spawn()'s shell option is unconditionally set to false when fork() is called. Refs: nodejs/node#15299 Fixes: nodejs/node#13983 PR-URL: nodejs/node#15352 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>

This commit verifies that the child_process fork() method does not honor the shell option. Refs: nodejs/node#15299 PR-URL: nodejs/node#15352 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>

This commit ensures that spawn()'s shell option is unconditionally set to false when fork() is called. Refs: #15299 Fixes: #13983 PR-URL: #15352 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>

This commit verifies that the child_process fork() method does not honor the shell option. Refs: #15299 PR-URL: #15352 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>

This commit ensures that spawn()'s shell option is unconditionally set to false when fork() is called. Refs: #15299 Fixes: #13983 PR-URL: #15352 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>

This commit verifies that the child_process fork() method does not honor the shell option. Refs: #15299 PR-URL: #15352 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>

This commit ensures that spawn()'s shell option is unconditionally set to false when fork() is called. Refs: #15299 Fixes: #13983 PR-URL: #15352 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>

This commit verifies that the child_process fork() method does not honor the shell option. Refs: #15299 PR-URL: #15352 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>

Update child_process.js

77d1427

nodejs-github-bot added the child_process Issues and PRs related to the child_process subsystem. label Sep 9, 2017

Create test-child-process-fork-noshell.js

ee7a941

Test for #15299

Update child_process.js

2248edb

ghost changed the title ~~child_process: remove shell option before win32 fork spawn~~ child_process: remove shell option before fork Sep 10, 2017

Documentation update #13983

a35f2f9

cjihrig requested changes Sep 10, 2017

View reviewed changes

cjihrig mentioned this pull request Sep 12, 2017

child_process: set shell to false in fork() #15352

Merged

4 tasks

cjihrig closed this Sep 12, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

child_process: remove shell option before fork #15299

child_process: remove shell option before fork #15299

ghost commented Sep 9, 2017 •

edited by ghost

Loading

cjihrig commented Sep 9, 2017

ghost commented Sep 9, 2017 •

edited by ghost

Loading

ghost commented Sep 9, 2017

cjihrig commented Sep 10, 2017

cjihrig left a comment

cjihrig Sep 10, 2017

cjihrig Sep 10, 2017

cjihrig Sep 10, 2017

cjihrig Sep 10, 2017

Fishrock123 commented Sep 11, 2017

cjihrig commented Sep 11, 2017

cjihrig commented Sep 12, 2017

		@@ -0,0 +1,29 @@
		// Copyright Joyent, Inc. and other Node contributors.

child_process: remove shell option before fork #15299

child_process: remove shell option before fork #15299

Conversation

ghost commented Sep 9, 2017 • edited by ghost Loading

Checklist

Affected core subsystem(s)

cjihrig commented Sep 9, 2017

ghost commented Sep 9, 2017 • edited by ghost Loading

ghost commented Sep 9, 2017

cjihrig commented Sep 10, 2017

cjihrig left a comment

Choose a reason for hiding this comment

cjihrig Sep 10, 2017

Choose a reason for hiding this comment

cjihrig Sep 10, 2017

Choose a reason for hiding this comment

cjihrig Sep 10, 2017

Choose a reason for hiding this comment

cjihrig Sep 10, 2017

Choose a reason for hiding this comment

Fishrock123 commented Sep 11, 2017

cjihrig commented Sep 11, 2017

cjihrig commented Sep 12, 2017

ghost commented Sep 9, 2017 •

edited by ghost

Loading

ghost commented Sep 9, 2017 •

edited by ghost

Loading