Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http2: store headersSent after stream destroyed #15232

Closed
wants to merge 1 commit into from
Closed

http2: store headersSent after stream destroyed #15232

wants to merge 1 commit into from

Conversation

apapirovski
Copy link
Member

Store headersSent directly on response state after finish event is triggered, so that users can always access it.

Fixes: #15226

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

http2, test

@nodejs-github-bot nodejs-github-bot added the http2 Issues or PRs related to the http2 subsystem. label Sep 6, 2017
@apapirovski
http2: store headersSent after stream destroyed
a5d6a6f 
Store headersSent directly on response state after finish event
is triggered, so that users can always access it.

Fixes: nodejs#15226
@apapirovski
Copy link
Member Author

Had to rebase but no changes made.

@BridgeAR
Copy link
Member

BridgeAR commented Sep 9, 2017

https://ci.nodejs.org/job/node-test-pull-request/10013/

@ronag ronag mentioned this pull request Sep 10, 2017
Merged
@BridgeAR
Copy link
Member

Landed in 78fc726

@BridgeAR BridgeAR closed this Sep 11, 2017
BridgeAR pushed a commit that referenced this pull request Sep 11, 2017
@apapirovski @BridgeAR
http2: store headersSent after stream destroyed
78fc726 
Store headersSent directly on response state after finish event
is triggered, so that users can always access it.

PR-URL: #15232
Fixes: #15226
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Sep 12, 2017
@apapirovski @MylesBorins
http2: store headersSent after stream destroyed
d8ff550 
Store headersSent directly on response state after finish event
is triggered, so that users can always access it.

PR-URL: #15232
Fixes: #15226
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
addaleax pushed a commit to addaleax/node that referenced this pull request Sep 13, 2017
@apapirovski @addaleax
http2: store headersSent after stream destroyed
d0f85b1 
Store headersSent directly on response state after finish event
is triggered, so that users can always access it.

PR-URL: nodejs#15232
Fixes: nodejs#15226
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@apapirovski apapirovski deleted the patch-http2-compat-headerssent branch September 15, 2017 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tniessen tniessen tniessen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@benjamingr benjamingr benjamingr approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

http2 - headersSent internal?
9 participants
@apapirovski @BridgeAR @jasnell @benjamingr @lpinca @cjihrig @tniessen @MylesBorins @nodejs-github-bot