http2: store headersSent after stream destroyed #15232
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apapirovski
force-pushed
the
patch-http2-compat-headerssent
branch
from
74a9f3d to
e6f89cf
Compare
jasnell
approved these changes
Sep 6, 2017
cjihrig
approved these changes
Sep 6, 2017
benjamingr
approved these changes
Sep 7, 2017
Store headersSent directly on response state after finish event is triggered, so that users can always access it. Fixes: nodejs#15226
apapirovski
force-pushed
the
patch-http2-compat-headerssent
branch
from
e6f89cf to
a5d6a6f
Compare
|
Had to rebase but no changes made. |
lpinca
approved these changes
Sep 7, 2017
tniessen
approved these changes
Sep 10, 2017
Merged
|
Landed in 78fc726 |
BridgeAR
pushed a commit
that referenced
this pull request
Sep 11, 2017
Store headersSent directly on response state after finish event is triggered, so that users can always access it. PR-URL: #15232 Fixes: #15226 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Sep 12, 2017
Store headersSent directly on response state after finish event is triggered, so that users can always access it. PR-URL: #15232 Fixes: #15226 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Sep 13, 2017
Store headersSent directly on response state after finish event is triggered, so that users can always access it. PR-URL: nodejs#15232 Fixes: nodejs#15226 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store
headersSentdirectly on response state after finish event is triggered, so that users can always access it.Fixes: #15226
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
http2, test