Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc,lib,src,test: strip executable bits off files #15132

Closed
wants to merge 1 commit into from
Closed

doc,lib,src,test: strip executable bits off files #15132

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Sep 1, 2017

Remove the executable bits of the file modes of some files that
accidentally received it.

[test-reset-chmod 9b096063afaf] doc,lib,src,test: strip executable bits off files
 16 files changed, 0 insertions(+), 0 deletions(-)
 mode change 100755 => 100644 doc/api/child_process.md
 mode change 100755 => 100644 doc/api/http2.md
 mode change 100755 => 100644 doc/api/perf_hooks.md
 mode change 100755 => 100644 lib/internal/http2/core.js
 mode change 100755 => 100644 src/node_http2.cc
 mode change 100755 => 100644 src/node_http2.h
 mode change 100755 => 100644 src/node_http2_core-inl.h
 mode change 100755 => 100644 src/node_http2_core.h
 mode change 100755 => 100644 test/parallel/test-http2-client-unescaped-path.js
 mode change 100755 => 100644 test/parallel/test-http2-client-upload.js
 mode change 100755 => 100644 test/parallel/test-http2-info-headers.js
 mode change 100755 => 100644 test/parallel/test-http2-options-max-reserved-streams.js
 mode change 100755 => 100644 test/parallel/test-http2-response-splitting.js
 mode change 100755 => 100644 test/parallel/test-http2-server-socket-destroy.js
 mode change 100755 => 100644 test/parallel/test-http2-server-socketerror.js
 mode change 100755 => 100644 test/parallel/test-performance-gc.js

@jasnell ;)

@addaleax
doc,lib,src,test: strip executable bits off files
9b09606 
Remove the executable bits of the file modes of some files that
accidentally received it.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Sep 1, 2017
TimothyGu
TimothyGu approved these changes Sep 1, 2017
View reviewed changes
Copy link
Member

@TimothyGu TimothyGu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jasnell
Copy link
Member

jasnell commented Sep 1, 2017

sigh. thank you. I ended up blowing away my local github set up a few weeks ago and completely forgot to set the config switch to ignore those.

@jasnell
Copy link
Member

jasnell commented Sep 1, 2017 •
edited
Loading

it's switched on now! :-) (for those who don't know, this is what happens when the code is sitting in an Ubuntu VM and you're using Visual Studio Code on Windows through a mapped drive to edit. The file permissions "helpfully" get changed for you.)

jasnell
jasnell approved these changes Sep 1, 2017
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't need to wait the 48 hours to land

jasnell pushed a commit that referenced this pull request Sep 1, 2017
@addaleax @jasnell
doc,lib,src,test: strip executable bits off files
dd52cad 
Remove the executable bits of the file modes of some files that
accidentally received it.

PR-URL: #15132
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

jasnell commented Sep 1, 2017

Landed in dd52cad

@jasnell jasnell closed this Sep 1, 2017
addaleax added a commit to addaleax/ayo that referenced this pull request Sep 5, 2017
@addaleax
doc,lib,src,test: strip executable bits off files
5e79b91 
Remove the executable bits of the file modes of some files that
accidentally received it.

PR-URL: nodejs/node#15132
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Sep 10, 2017
@addaleax @MylesBorins
doc,lib,src,test: strip executable bits off files
8f18cc1 
Remove the executable bits of the file modes of some files that
accidentally received it.

PR-URL: #15132
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Sep 10, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Sep 11, 2017
@addaleax @MylesBorins
doc,lib,src,test: strip executable bits off files
eb30cbc 
Remove the executable bits of the file modes of some files that
accidentally received it.

PR-URL: #15132
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Sep 12, 2017
@addaleax @MylesBorins
doc,lib,src,test: strip executable bits off files
aaf55db 
Remove the executable bits of the file modes of some files that
accidentally received it.

PR-URL: #15132
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@benjamingr benjamingr benjamingr approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@addaleax @jasnell @benjamingr @TimothyGu @targos @cjihrig @MylesBorins @nodejs-github-bot