-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc,lib,src,test: strip executable bits off files #15132
Conversation
Remove the executable bits of the file modes of some files that accidentally received it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
sigh. thank you. I ended up blowing away my local github set up a few weeks ago and completely forgot to set the config switch to ignore those. |
it's switched on now! :-) (for those who don't know, this is what happens when the code is sitting in an Ubuntu VM and you're using Visual Studio Code on Windows through a mapped drive to edit. The file permissions "helpfully" get changed for you.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't need to wait the 48 hours to land
Remove the executable bits of the file modes of some files that accidentally received it. PR-URL: #15132 Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]>
Landed in dd52cad |
Remove the executable bits of the file modes of some files that accidentally received it. PR-URL: nodejs/node#15132 Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]>
Remove the executable bits of the file modes of some files that accidentally received it. PR-URL: #15132 Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]>
Remove the executable bits of the file modes of some files that accidentally received it. PR-URL: #15132 Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]>
Remove the executable bits of the file modes of some files that accidentally received it. PR-URL: #15132 Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]>
Remove the executable bits of the file modes of some files that
accidentally received it.
@jasnell ;)