Revert "http2: refactor error handling"

[Trott]

This reverts commit 4ca8ff2.

After this lands (hopefully promptly), #14991 should be re-opened and re-landed after the test failures are fixed.

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes

Affected core subsystem(s)

http2

[Trott]

@jasnell @mcollina

[Trott]

Sample test failure this revert will fix:

https://ci.nodejs.org/job/node-test-binary-windows/10729/RUN_SUBSET=1,VS_VERSION=vcbt2015,label=win10/console

not ok 202 parallel/test-http2-respond-file-404
  ---
  duration_ms: 0.170
  severity: fail
  stack: |-
    (node:4708) ExperimentalWarning: The http2 module is an experimental API.
    assert.js:42
      throw new errors.AssertionError({
      ^
    
    AssertionError [ERR_ASSERTION]: 'ENOENT: no such file or directory, open \'c:\\workspace\\node-test-binary-windows\\RUN_SUBSET\\1\\VS_VERSION\\vcbt2015\\label\\ === 'ENOENT: no such file or directory, open \'./not-a-file\''
        at c:\workspace\node-test-binary-windows\RUN_SUBSET\1\VS_VERSION\vcbt2015\label\win10\test\common\index.js:715:16
        at c:\workspace\node-test-binary-windows\RUN_SUBSET\1\VS_VERSION\vcbt2015\label\win10\test\common\index.js:509:15
        at onError (c:\workspace\node-test-binary-windows\RUN_SUBSET\1\VS_VERSION\vcbt2015\label\win10\test\parallel\test-http2-respond-file-404.js:25:9)
        at ServerHttp2Stream.afterOpen (internal/http2/core.js:1704:7)
        at FSReqWrap.oncomplete (fs.js:135:15)

[jasnell]

O.o not sure how that happened but lgtm! And +1 to fast track

[Trott]

CI: https://ci.nodejs.org/job/node-test-pull-request/9847/

[jasnell]

Have a distinct feeling I simply missed the failure before landing due to the issues we were having with ci. Good catch on it. I'll reopen the pr and revisit on Monday

[jasnell]

Thank you @Trott!

[Trott]

due to the issues we were having with ci

Yeah, no kidding. As if we needed it, it's a good reminder of the importance of keeping CI reliably green. Otherwise, it gets ignored when the red actually means something.

On that front, I went in and fixed the reliably-failing CentOS 5 test machine. (I usually don't bother because I feel like I don't know what I'm doing. But it's a weekend and how much damage could I do by logging in and restarting the Jenkins agent? Didn't actually think it would work but...it did.)

So, hopefully once this lands, we're back to green, or at least yellow.

[Trott]

Landed in f912080

[mcollina]

Sorry for this, I had a couple of busy days and I didn't check if there were problems in CI. I typically check when landing. I'll update the original PR.