Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: cherry-pick 0ef4a0c64b6 from c-ares upstream #15023

Closed
wants to merge 2 commits into from
Closed

deps: cherry-pick 0ef4a0c64b6 from c-ares upstream #15023

wants to merge 2 commits into from

Conversation

addaleax
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

dns

@addaleax
deps: cherry-pick 0ef4a0c64b6 from c-ares upstream
089b24e 
Original commit message:

  gethostbyaddr: fail with `ECANCELLED` for `ares_cancel()`

  When `ares_cancel()` was invoked, `ares_gethostbyaddr()`
  queries would fail with `ENOTFOUND` instead of `ECANCELLED`.

  It seems appropriate to treat `ares_cancel()` like `ares_destroy()`,
  but I would appreciate review of the correctness of this change.

  Ref: nodejs#14814

Fixes: nodejs#14814
@addaleax
test: add regression test for 14814
32c5a63 
Ref: nodejs#14814
@nodejs-github-bot nodejs-github-bot added the cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. label Aug 24, 2017
@addaleax addaleax changed the title Deps cares deps: cherry-pick 0ef4a0c64b6 from c-ares upstream Aug 24, 2017
@addaleax
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-commit/12062/

Can somebody else merge it if CI comes back good? I'm offline in a couple minutes again.

@addaleax
Copy link
Member Author

CI is looking good, all failures are infrastructure-related

jasnell pushed a commit that referenced this pull request Aug 29, 2017
@addaleax @jasnell
deps: cherry-pick 0ef4a0c64b6 from c-ares upstream
a26be68 
Original commit message:

  gethostbyaddr: fail with `ECANCELLED` for `ares_cancel()`

  When `ares_cancel()` was invoked, `ares_gethostbyaddr()`
  queries would fail with `ENOTFOUND` instead of `ECANCELLED`.

  It seems appropriate to treat `ares_cancel()` like `ares_destroy()`,
  but I would appreciate review of the correctness of this change.

  Ref: #14814

Fixes: #14814

PR-URL: #15023
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
jasnell pushed a commit that referenced this pull request Aug 29, 2017
@addaleax @jasnell
test: add regression test for 14814
5c0d64e 
Ref: #14814

PR-URL: #15023
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@jasnell
Copy link
Member

jasnell commented Aug 29, 2017

Landed in a26be68 and 5c0d64e

@jasnell jasnell closed this Aug 29, 2017
ghost pushed a commit to ayojs/ayo that referenced this pull request Aug 30, 2017
@addaleax
deps: cherry-pick 0ef4a0c64b6 from c-ares upstream
b8823b5 
Original commit message:

  gethostbyaddr: fail with `ECANCELLED` for `ares_cancel()`

  When `ares_cancel()` was invoked, `ares_gethostbyaddr()`
  queries would fail with `ENOTFOUND` instead of `ECANCELLED`.

  It seems appropriate to treat `ares_cancel()` like `ares_destroy()`,
  but I would appreciate review of the correctness of this change.

  Ref: nodejs/node#14814

Fixes: nodejs/node#14814

PR-URL: nodejs/node#15023
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
ghost pushed a commit to ayojs/ayo that referenced this pull request Aug 30, 2017
@addaleax
test: add regression test for 14814
00823bc 
Ref: nodejs/node#14814

PR-URL: nodejs/node#15023
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
ghost pushed a commit to ayojs/ayo that referenced this pull request Aug 30, 2017
@addaleax
deps: cherry-pick 0ef4a0c64b6 from c-ares upstream
76627ee 
Original commit message:

  gethostbyaddr: fail with `ECANCELLED` for `ares_cancel()`

  When `ares_cancel()` was invoked, `ares_gethostbyaddr()`
  queries would fail with `ENOTFOUND` instead of `ECANCELLED`.

  It seems appropriate to treat `ares_cancel()` like `ares_destroy()`,
  but I would appreciate review of the correctness of this change.

  Ref: nodejs/node#14814

Fixes: nodejs/node#14814

PR-URL: nodejs/node#15023
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
ghost pushed a commit to ayojs/ayo that referenced this pull request Aug 30, 2017
@addaleax
test: add regression test for 14814
385aa93 
Ref: nodejs/node#14814

PR-URL: nodejs/node#15023
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
cjihrig pushed a commit to cjihrig/node that referenced this pull request Aug 31, 2017
@addaleax @cjihrig
deps: cherry-pick 0ef4a0c64b6 from c-ares upstream
f04eb9e 
Original commit message:

  gethostbyaddr: fail with `ECANCELLED` for `ares_cancel()`

  When `ares_cancel()` was invoked, `ares_gethostbyaddr()`
  queries would fail with `ENOTFOUND` instead of `ECANCELLED`.

  It seems appropriate to treat `ares_cancel()` like `ares_destroy()`,
  but I would appreciate review of the correctness of this change.

  Ref: nodejs#14814

Fixes: nodejs#14814

PR-URL: nodejs#15023
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
cjihrig pushed a commit to cjihrig/node that referenced this pull request Aug 31, 2017
@addaleax @cjihrig
test: add regression test for 14814
43812cb 
Ref: nodejs#14814

PR-URL: nodejs#15023
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Sep 10, 2017
@addaleax @MylesBorins
deps: cherry-pick 0ef4a0c64b6 from c-ares upstream
02befa1 
Original commit message:

  gethostbyaddr: fail with `ECANCELLED` for `ares_cancel()`

  When `ares_cancel()` was invoked, `ares_gethostbyaddr()`
  queries would fail with `ENOTFOUND` instead of `ECANCELLED`.

  It seems appropriate to treat `ares_cancel()` like `ares_destroy()`,
  but I would appreciate review of the correctness of this change.

  Ref: #14814

Fixes: #14814

PR-URL: #15023
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Sep 10, 2017
@addaleax @MylesBorins
test: add regression test for 14814
5e910a6 
Ref: #14814

PR-URL: #15023
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Sep 10, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Sep 12, 2017
@addaleax @MylesBorins
deps: cherry-pick 0ef4a0c64b6 from c-ares upstream
296729c 
Original commit message:

  gethostbyaddr: fail with `ECANCELLED` for `ares_cancel()`

  When `ares_cancel()` was invoked, `ares_gethostbyaddr()`
  queries would fail with `ENOTFOUND` instead of `ECANCELLED`.

  It seems appropriate to treat `ares_cancel()` like `ares_destroy()`,
  but I would appreciate review of the correctness of this change.

  Ref: #14814

Fixes: #14814

PR-URL: #15023
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Sep 12, 2017
@addaleax @MylesBorins
test: add regression test for 14814
458b8ab 
Ref: #14814

PR-URL: #15023
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@rvagg rvagg mentioned this pull request Sep 13, 2017
Closed
rvagg pushed a commit to rvagg/io.js that referenced this pull request Sep 13, 2017
@addaleax @rvagg
deps: cherry-pick 0ef4a0c64b6 from c-ares upstream
b02613f 
Original commit message:

  gethostbyaddr: fail with `ECANCELLED` for `ares_cancel()`

  When `ares_cancel()` was invoked, `ares_gethostbyaddr()`
  queries would fail with `ENOTFOUND` instead of `ECANCELLED`.

  It seems appropriate to treat `ares_cancel()` like `ares_destroy()`,
  but I would appreciate review of the correctness of this change.

  Ref: nodejs#14814

Fixes: nodejs#14814

PR-URL: nodejs#15023
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
BridgeAR pushed a commit that referenced this pull request Oct 2, 2017
@addaleax @BridgeAR
deps: cherry-pick 0ef4a0c64b6 from c-ares upstream
50e580d 
Original commit message:

  gethostbyaddr: fail with `ECANCELLED` for `ares_cancel()`

  When `ares_cancel()` was invoked, `ares_gethostbyaddr()`
  queries would fail with `ENOTFOUND` instead of `ECANCELLED`.

  It seems appropriate to treat `ares_cancel()` like `ares_destroy()`,
  but I would appreciate review of the correctness of this change.

  Ref: #14814

Fixes: #14814

PR-URL: #15023
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
addaleax added a commit to addaleax/ayo that referenced this pull request Oct 4, 2017
@addaleax
deps: cherry-pick 0ef4a0c64b6 from c-ares upstream
8c1f5b5 
Original commit message:

  gethostbyaddr: fail with `ECANCELLED` for `ares_cancel()`

  When `ares_cancel()` was invoked, `ares_gethostbyaddr()`
  queries would fail with `ENOTFOUND` instead of `ECANCELLED`.

  It seems appropriate to treat `ares_cancel()` like `ares_destroy()`,
  but I would appreciate review of the correctness of this change.

  Ref: nodejs/node#14814

Fixes: nodejs/node#14814

PR-URL: nodejs/node#15023
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
cares Issues and PRs related to the c-ares dependency or the cares_wrap binding.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@addaleax @jasnell @cjihrig @nodejs-github-bot