Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

errors: remove duplicated ERR_HTTP_INVALID_STATUS_CODE error #15003

Closed
wants to merge 1 commit into from
Closed

errors: remove duplicated ERR_HTTP_INVALID_STATUS_CODE error #15003

wants to merge 1 commit into from

Conversation

maclover7
Copy link
Contributor

@maclover7 maclover7 commented Aug 24, 2017 •
edited
Loading

Fairly self-explanatory, but there are two listings of ERR_HTTP_INVALID_STATUS_CODE in lib/internal/errors.js, so one needed to be removed.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

errors

@nodejs-github-bot nodejs-github-bot added the errors Issues and PRs related to JavaScript errors originated in Node.js core. label Aug 24, 2017
Trott
Trott approved these changes Aug 24, 2017
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI runs without incident.

I believe we try to keep those codes in alphabetical order, so maybe while you're in there, move the nearby ERR_HTTP_TRAILER_INVALID to the right place?

@maclover7
Copy link
Contributor Author

@Trott yep, was planning on opening up an issue to grab feedback about keeping the errors in alphabetical order, and also making sure the docs are in sync with the list of errors, there are a bunch of discrepancies right now 😞

@Trott
Copy link
Member

Trott commented Aug 24, 2017

@Trott yep, was planning on opening up an issue to grab feedback about keeping the errors in alphabetical order, and also making sure the docs are in sync with the list of errors, there are a bunch of discrepancies right now 😞

Awesome. Thanks for doing the work of identifying the issues and correcting them!

hiroppy pushed a commit to hiroppy/node that referenced this pull request Aug 27, 2017
@maclover7 @hiroppy
errors: remove duplicated ERR_HTTP_INVALID_STATUS_CODE error
0097794 
PR-URL: nodejs#15003
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@hiroppy
Copy link
Member

hiroppy commented Aug 27, 2017

landed in 0097794

@hiroppy hiroppy closed this Aug 27, 2017
ghost pushed a commit to ayojs/ayo that referenced this pull request Aug 30, 2017
@maclover7
errors: remove duplicated ERR_HTTP_INVALID_STATUS_CODE error
cfdb615 
PR-URL: nodejs/node#15003
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
ghost pushed a commit to ayojs/ayo that referenced this pull request Aug 30, 2017
@maclover7
errors: remove duplicated ERR_HTTP_INVALID_STATUS_CODE error
86facde 
PR-URL: nodejs/node#15003
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins pushed a commit that referenced this pull request Sep 10, 2017
@maclover7 @MylesBorins
errors: remove duplicated ERR_HTTP_INVALID_STATUS_CODE error
560ef97 
PR-URL: #15003
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Sep 10, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Sep 11, 2017
@maclover7 @MylesBorins
errors: remove duplicated ERR_HTTP_INVALID_STATUS_CODE error
7018405 
PR-URL: #15003
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins pushed a commit that referenced this pull request Sep 12, 2017
@maclover7 @MylesBorins
errors: remove duplicated ERR_HTTP_INVALID_STATUS_CODE error
ea2b576 
PR-URL: #15003
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@maclover7 maclover7 deleted the jm-rm-dup-error branch July 14, 2018 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiroppy hiroppy hiroppy approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

@danbev danbev danbev approved these changes

Assignees
No one assigned
Labels
errors Issues and PRs related to JavaScript errors originated in Node.js core.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@maclover7 @Trott @hiroppy @danbev @jasnell @lpinca @cjihrig @MylesBorins @nodejs-github-bot