Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update http2.md #14979

Closed
wants to merge 1 commit into from
Closed

Update http2.md #14979

wants to merge 1 commit into from

Conversation

RefinedSoftwareLLC
Copy link
Contributor

"require('http');" should be "require('http2');"

Affected core subsystem(s)

doc
http2

@RefinedSoftwareLLC
Update http2.md
79cb0dc 
"require('http');" should be "require('http2');"
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem. labels Aug 22, 2017
@jasnell
Copy link
Member

jasnell commented Aug 22, 2017

This should not need to wait the full 48 hours to land

@lance lance self-assigned this Aug 22, 2017
@lance
Copy link
Member

lance commented Aug 22, 2017

Landed in d70d36b

@lance lance closed this Aug 22, 2017
lance pushed a commit that referenced this pull request Aug 22, 2017
@RefinedSoftwareLLC @lance
doc: update http2.md example code
d70d36b 
`require('http');` should be `require('http2');`

PR-URL: #14979
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
addaleax pushed a commit to addaleax/ayo that referenced this pull request Aug 25, 2017
@RefinedSoftwareLLC @addaleax
doc: update http2.md example code
6682448 
`require('http');` should be `require('http2');`

PR-URL: nodejs/node#14979
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Aug 28, 2017
@RefinedSoftwareLLC @addaleax
doc: update http2.md example code
16813ca 
`require('http');` should be `require('http2');`

PR-URL: nodejs/node#14979
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Sep 10, 2017
@RefinedSoftwareLLC @MylesBorins
doc: update http2.md example code
3094990 
`require('http');` should be `require('http2');`

PR-URL: #14979
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Sep 10, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Sep 12, 2017
@RefinedSoftwareLLC @MylesBorins
doc: update http2.md example code
78b2bc7 
`require('http');` should be `require('http2');`

PR-URL: #14979
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees

@lance lance

Labels
doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@RefinedSoftwareLLC @jasnell @lance @addaleax @lpinca @cjihrig @MylesBorins @nodejs-github-bot