Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: rephrase wording of child_process.execSync() #14953

Closed
wants to merge 2 commits into from
Closed

doc: rephrase wording of child_process.execSync() #14953

wants to merge 2 commits into from

Conversation

ayazhafiz
Copy link
Contributor

Rephrases the error thrown by child_process.execSync().

Fixes: #14944

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

@ayazhafiz
doc: rephrase wording of child_process.execSync()
416ea4f 
Rephrases the error thrown by child_process.execSync().

Fixes: nodejs#14944
@nodejs-github-bot nodejs-github-bot added child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to the documentations. labels Aug 20, 2017
lpinca
lpinca reviewed Aug 20, 2017
View reviewed changes
doc/api/child_process.md Outdated
throw. The [`Error`][] object will contain the entire result from
[`child_process.spawnSync()`][]
throw an [`Error`][] that will include the full result of the underlying
[`spawnSync()`][].
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would keep the child_process. prefix for consistency.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

considering this nit, rest all LGTM.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed, should be fixed now!

@refack refack self-assigned this Aug 20, 2017
jasnell pushed a commit that referenced this pull request Aug 23, 2017
@ayazhafiz @jasnell
doc: rephrase text of child_process.execSync()
e76b1ff 
Rephrases the error thrown by child_process.execSync().

PR-URL: #14953
Fixes: #14944
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@jasnell
Copy link
Member

jasnell commented Aug 23, 2017

Landed in e76b1ff

@jasnell jasnell closed this Aug 23, 2017
@refack refack removed their assignment Aug 23, 2017
addaleax pushed a commit to addaleax/ayo that referenced this pull request Aug 25, 2017
@ayazhafiz @addaleax
doc: rephrase text of child_process.execSync()
a2c7871 
Rephrases the error thrown by child_process.execSync().

PR-URL: nodejs/node#14953
Fixes: nodejs/node#14944
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Aug 28, 2017
@ayazhafiz @addaleax
doc: rephrase text of child_process.execSync()
d9a1740 
Rephrases the error thrown by child_process.execSync().

PR-URL: nodejs/node#14953
Fixes: nodejs/node#14944
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Sep 10, 2017
@ayazhafiz @MylesBorins
doc: rephrase text of child_process.execSync()
bf7b79d 
Rephrases the error thrown by child_process.execSync().

PR-URL: #14953
Fixes: #14944
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Sep 10, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Sep 12, 2017
@ayazhafiz @MylesBorins
doc: rephrase text of child_process.execSync()
57c7eae 
Rephrases the error thrown by child_process.execSync().

PR-URL: #14953
Fixes: #14944
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Sep 20, 2017
@ayazhafiz @MylesBorins
doc: rephrase text of child_process.execSync()
7546eef 
Rephrases the error thrown by child_process.execSync().

PR-URL: #14953
Fixes: #14944
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Sep 20, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daxlab daxlab daxlab approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

@refack refack refack approved these changes

Assignees
No one assigned
Labels
child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@ayazhafiz @jasnell @refack @lpinca @cjihrig @daxlab @MylesBorins @nodejs-github-bot