deps: backport d727680 from V8 upstream

[matthewloring]

Original commit message:

[d8] Bring PredictablePlatform in line with default platform
This removes a lot of special handling for the predictable platform.
Instead of executing spawned foreground and background tasks
immediately (i.e. inside the scope that spawns the tasks), just add
both to the foreground task queue.

This avoids existing special handling for predictable mode in wasm
async compilation, and should fix current failures on the predictable
bot.

BUG=v8:6427

Change-Id: Idbaa764a3dc8c230c29f3937d885e12174691ac4
Reviewed-on: https://chromium-review.googlesource.com/509694
Reviewed-by: Jochen Eisinger [email protected]
Commit-Queue: Clemens Hammacher [email protected]
Cr-Commit-Position: refs/heads/master@{#45538}

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

Affected core subsystem(s)

[matthewloring]

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/866/

[matthewloring]

It looks like there are still compilation failures on the nodes=benchmark configuration but the others are green.

[matthewloring]

V8 ci is now green: https://ci.nodejs.org/job/node-test-commit-v8-linux/867/

[matthewloring]

Node CI: https://ci.nodejs.org/job/node-test-pull-request/9751/

[refack]

Some "procedural" questions:

1. I tried to compare to https://chromium-review.googlesource.com/509694 but saw significant diff - https://www.diffchecker.com/qchO3Yt3.
   Can you give some comments on that? (Obviously if the diff is the same we could just rubberstamp).
   If the cherrypick required manual massaging it would be great if you could separate it into 2 commit for easy review. Otherwise even if you simply tl;dr the required changes, that would help me review.

2. I see this landed in 6.1.1 and the others from src: Node implementation of v8::Platform #14001 other patch version of 6.1 could you add that to the commit message, so when we bump to 6.1 we know there's no need to re-float this.

/cc @nodejs/v8

[MylesBorins]

@refack fwiw I went through with the tool and double checked all floated patches before landing them to see whether or not they were in the latest release

[seishun]

Is it even possibly to re-float a patch that's already in the release? I would assume git would skip it as an empty commit.

[refack]

Is it even possibly to re-float a patch that's already in the release? I would assume git would skip it as an empty commit.

Or conflict, and then you need to figure out what's the story. But if there's a tool and a procedure, than my point is moot.

[jasnell]

rubber stamp lgtm

[targos]

Please s/cherry-pick/backport/ because this is not a clean cherry-pick.

[matthewloring]

@refack The TL;DR is that I applied v8/v8@d727680 and then resolved the merge conflicts in PredictablePlatform. These were mostly caused by the fact that the GetTracingController portion of the change had already landed in node. I don't recall making any other changes.

The procedural question I had was how to handle the second commit in this PR. It is not related to the backport and is not implemented in V8 since the affected file no longer existed in V8 when CancelableTaskManager::Id was added. Should I open this as a separate PR?

[matthewloring]

@targos Updated the name to backport.

[refack]

50% Rubberstamp
40% git procedures
10% Review

[MylesBorins]

LGMT if CI is green (V8 CI :P)

[matthewloring]

@MylesBorins @targos Any thoughts on the second commit? Should it be squashed or left as its own commit?

[ofrobots]

Squash, given the understanding that the first commit won't compile just by itself.

[matthewloring]

Ok, I'll plan to squash and land this tomorrow morning if nobody else has concerns.

[matthewloring]

Landed in d348512. V8 CI should be happy again 😸

[MylesBorins]

Should this be backported to v6.x-staging? If yes please follow the guide and raise a backport PR, if no let me know or add the dont-land-on label.