Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove unsused arguments from function #14931

Closed
wants to merge 2 commits into from
Closed

test: remove unsused arguments from function #14931

wants to merge 2 commits into from

Conversation

0xparashar
Copy link
Contributor

Removed the unused arguments of functions defined in
file test/parallel/test-http-parser.js

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
test

@0xparashar
test: remove unsused arguments from function
75ee6f3 
Removed the unused arguments of functions defined in
file test/parallel/test-http-parser.js
@mscdex
Copy link
Contributor

mscdex commented Aug 18, 2017 •
edited
Loading

Looks like there is a 'venv' directory that was incorrectly included in the commit and should be removed.

@mscdex mscdex added http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests. labels Aug 18, 2017
@0xparashar
Copy link
Contributor Author

removed that with the latest commit :)

Trott
Trott approved these changes Aug 18, 2017
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, @ankitiitb1069! Thanks for the PR! LGTM if CI run is successful.

@Trott
Copy link
Member

Trott commented Aug 18, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/9745/

@refack
Copy link
Contributor

refack commented Aug 19, 2017

Hello @ankitiitb1069 and welcome, GitHub is indicating this is your first contribution, so just in case you havn't already, it's recommended to take a look at the CONTRIBUTING.md guide (especialy the part about "discuss and update").
PRs are left open for at least 48 hour so that anyone interested gets a chance to comment or review.

Anyway thank you for the contribution, and good luck.

@tniessen tniessen self-assigned this Aug 20, 2017
@aqrln
Copy link
Contributor

aqrln commented Aug 22, 2017

Hi @ankitiitb1069 and thanks for your contribution! I have started a fresh CI run since node-test-commit-osx and node-test-commit-linux-fips jobs didn't even start running during the old one. Once it finishes, the patch is good to land.

CI: https://ci.nodejs.org/job/node-test-pull-request/9794/

@tniessen
Copy link
Member

Landed in 2a97eb6, thank you for your contribution! 🎉

@tniessen tniessen closed this Aug 23, 2017
tniessen pushed a commit that referenced this pull request Aug 23, 2017
@0xparashar @tniessen
test: remove unused arguments from function
2a97eb6 
Removed the unused arguments of functions defined in
file test/parallel/test-http-parser.js.

PR-URL: #14931
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Alexey Orlenko <[email protected]>
addaleax pushed a commit to addaleax/ayo that referenced this pull request Aug 25, 2017
@0xparashar @addaleax
test: remove unused arguments from function
c2e50f1 
Removed the unused arguments of functions defined in
file test/parallel/test-http-parser.js.

PR-URL: nodejs/node#14931
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Alexey Orlenko <[email protected]>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Aug 28, 2017
@0xparashar @addaleax
test: remove unused arguments from function
c14fa56 
Removed the unused arguments of functions defined in
file test/parallel/test-http-parser.js.

PR-URL: nodejs/node#14931
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Alexey Orlenko <[email protected]>
MylesBorins pushed a commit that referenced this pull request Sep 10, 2017
@0xparashar @MylesBorins
test: remove unused arguments from function
f51c19c 
Removed the unused arguments of functions defined in
file test/parallel/test-http-parser.js.

PR-URL: #14931
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Alexey Orlenko <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Sep 10, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Sep 12, 2017
@0xparashar @MylesBorins
test: remove unused arguments from function
6421a9c 
Removed the unused arguments of functions defined in
file test/parallel/test-http-parser.js.

PR-URL: #14931
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Alexey Orlenko <[email protected]>
MylesBorins pushed a commit that referenced this pull request Sep 20, 2017
@0xparashar @MylesBorins
test: remove unused arguments from function
915b56b 
Removed the unused arguments of functions defined in
file test/parallel/test-http-parser.js.

PR-URL: #14931
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Alexey Orlenko <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Sep 20, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refack refack refack approved these changes

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@hiroppy hiroppy hiroppy approved these changes

@aqrln aqrln aqrln approved these changes

Assignees

@tniessen tniessen

Labels
http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.