doc: minor fixes to http/2 docs #14877
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
addaleax
approved these changes
Aug 16, 2017
| @@ -1725,7 +1725,7 @@ those to lower-case (e.g. `content-type`) upon transmission. | |||
|
|
|||
| Header field-names *must only* contain one or more of the following ASCII | |||
| characters: `a`-`z`, `A`-`Z`, `0`-`9`, `!`, `#`, `$`, `%`, `&`, `'`, `*`, `+`, | |||
| `-`, `.`, `^`, `_`, `` (backtick), `|`, and `~`. | |||
| `-`, `.`, `^`, `_`, `` (backtick)`, `|`, and `~`. | |||
There was a problem hiding this comment.
I think this maybe would be better with (backtick) in plain (non-code) text? i.e. `^`, `_`, `` ` `` (backtick), `|`, …
jasnell
approved these changes
Aug 17, 2017
cjihrig
approved these changes
Aug 17, 2017
lpinca
approved these changes
Aug 17, 2017
|
Landed in 39dd230 (with my nit addressed), thanks for the PR and welcome! |
addaleax
pushed a commit
that referenced
this pull request
Aug 20, 2017
PR-URL: #14877 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Sep 10, 2017
PR-URL: #14877 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Sep 12, 2017
PR-URL: #14877 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor updates to HTTP/2 documentation
Checklist
Affected core subsystem(s)
doc